Hlsl asuint16 function #132315
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| // RUN: %clang_cc1 -finclude-default-header -x hlsl -triple dxil-pc-shadermodel6.2-library %s -fnative-half-type -emit-llvm -O1 -o - | FileCheck %s | ||
|
|
||
| //CHECK-LABEL: define {{.*}}test_ints | ||
| //CHECK-SAME: {{.*}}(i16 {{.*}} [[VAL:%.*]]){{.*}} | ||
| // CHECK-NOT: bitcast | ||
|
||
| //CHECK: entry: | ||
| // CHECK: ret i16 [[VAL]] | ||
| uint16_t test_int(int16_t p0) | ||
| { | ||
| return asuint16(p0); | ||
| } | ||
|
|
||
| //CHECK-LABEL: define {{.*}}test_uint | ||
| //CHECK-SAME: {{.*}}(i16 {{.*}} [[VAL:%.*]]){{.*}} | ||
| //CHECK-NOT: bitcast | ||
| //CHECK: entry: | ||
| //CHECK-NEXT: ret i16 [[VAL]] | ||
| uint16_t test_uint(uint16_t p0) | ||
| { | ||
| return asuint16(p0); | ||
| } | ||
|
|
||
| //CHECK-LABEL: define {{.*}}test_half | ||
| //CHECK-SAME: {{.*}}(half {{.*}} [[VAL:%.*]]){{.*}} | ||
| //CHECK: [[RES:%.*]] = bitcast half [[VAL]] to i16 | ||
| //CHECK-NEXT: ret i16 [[RES]] | ||
| uint16_t test_half(half p0) | ||
| { | ||
| return asuint16(p0); | ||
| } | ||
|
|
||
| //CHECK-LABEL: define {{.*}}test_vector_int | ||
| //CHECK-SAME: {{.*}}(<4 x i16> {{.*}} [[VAL:%.*]]){{.*}} | ||
| //CHECK-NOT: bitcast | ||
| //CHECK: entry: | ||
| //CHECK-NEXT: ret <4 x i16> [[VAL]] | ||
| uint16_t4 test_vector_int(int16_t4 p0) | ||
| { | ||
| return asuint16(p0); | ||
| } | ||
|
|
||
| //CHECK-LABEL: define {{.*}}test_vector_uint | ||
| //CHECK-SAME: {{.*}}(<4 x i16> {{.*}} [[VAL:%.*]]){{.*}} | ||
| //CHECK-NOT: bitcast | ||
| //CHECK: entry: | ||
| //CHECK-NEXT: ret <4 x i16> [[VAL]] | ||
| uint16_t4 test_vector_uint(uint16_t4 p0) | ||
| { | ||
| return asuint16(p0); | ||
| } | ||
|
|
||
| //CHECK-LABEL: define {{.*}}fn | ||
| //CHECK-SAME: {{.*}}(<4 x half> {{.*}} [[VAL:%.*]]){{.*}} | ||
| //CHECK: [[RES:%.*]] = bitcast <4 x half> [[VAL]] to <4 x i16> | ||
| //CHECK-NEXT: ret <4 x i16> [[RES]] | ||
| uint16_t4 fn(half4 p1) | ||
| { | ||
| return asuint16(p1); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| // RUN: %clang_cc1 -finclude-default-header -triple dxil-pc-shadermodel6.2-library %s -fnative-half-type -verify | ||
|
|
||
| uint16_t test_asuint16_less_argument() | ||
| { | ||
| return asuint16(); | ||
| // expected-error@-1 {{no matching function for call to 'asuint16'}} | ||
| // expected-note@hlsl/hlsl_intrinsics.h:* {{candidate function template not viable: requires single argument 'V', but no arguments were provided}} | ||
| // expected-note@hlsl/hlsl_intrinsics.h:* {{candidate function template not viable: requires single argument 'F', but no arguments were provided}} | ||
|
|
||
| } | ||
|
|
||
| int16_t4 test_asuint16_too_many_arg(uint16_t p0, uint16_t p1) | ||
| { | ||
| return asuint16(p0, p1); | ||
| // expected-error@-1 {{no matching function for call to 'asuint16'}} | ||
| // expected-note@hlsl/hlsl_intrinsics.h:* {{candidate function template not viable: requires single argument 'V', but 2 arguments were provided}} | ||
| // expected-note@hlsl/hlsl_intrinsics.h:* {{candidate function template not viable: requires single argument 'F', but 2 arguments were provided}} | ||
|
|
||
| } | ||
|
|
||
| int16_t test_asuint16_int(int p1) | ||
| { | ||
| return asuint16(p1); | ||
| // expected-error@-1 {{no matching function for call to 'asuint16'}} | ||
| // expected-note@hlsl/hlsl_intrinsics.h:* {{candidate template ignored: could not match 'vector<T, N>' against 'int'}} | ||
| // expected-note@hlsl/hlsl_intrinsics.h:* {{candidate template ignored: substitution failure [with T = int]: no type named 'Type'}} | ||
|
Comment on lines
+25
to
+26
Contributor
There was a problem hiding this comment. Probably not an actionable item unless @farzonl has any ideas The notes here feel quite unhelpful from a user perspective. I'm guessing the error is that
Member
There was a problem hiding this comment. Since this is a language overload resolution rule and not one we defined in sema there is not much we can do in this PR. Atleast nothing that woudn't be considered scope creep. Worth talk with Chris about though and see if there is something we can change. |
||
| } | ||
|
|
||
| int16_t test_asuint16_float(float p1) | ||
| { | ||
| return asuint16(p1); | ||
| // expected-error@-1 {{no matching function for call to 'asuint16'}} | ||
| // expected-note@hlsl/hlsl_intrinsics.h:* {{candidate template ignored: could not match 'vector<T, N>' against 'float'}} | ||
| // expected-note@hlsl/hlsl_intrinsics.h:* {{candidate template ignored: substitution failure [with T = float]: no type named 'Type'}} | ||
| } | ||
|
|
||
| int16_t4 test_asuint16_vector_int(int4 p1) | ||
| { | ||
| return asuint16(p1); | ||
| // expected-error@-1 {{no matching function for call to 'asuint16'}} | ||
| // expected-note@hlsl/hlsl_intrinsics.h:* {{candidate template ignored: substitution failure [with T = int, N = 4]: no type named 'Type'}} | ||
| // expected-note@hlsl/hlsl_intrinsics.h:* {{candidate template ignored: substitution failure [with T = int4]: no type named 'Type'}} | ||
| } | ||
|
|
||
| int16_t4 test_asuint16_vector_float(float4 p1) | ||
| { | ||
| return asuint16(p1); | ||
| // expected-error@-1 {{no matching function for call to 'asuint16'}} | ||
| // expected-note@hlsl/hlsl_intrinsics.h:* {{candidate template ignored: substitution failure [with T = float, N = 4]: no type named 'Type'}} | ||
| // expected-note@hlsl/hlsl_intrinsics.h:* {{candidate template ignored: substitution failure [with T = float4]: no type named 'Type'}} | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| ; RUN: llc -O0 -verify-machineinstrs -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s | ||
| ; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %} | ||
|
|
||
| ; CHECK-DAG: %[[#half:]] = OpTypeFloat 16 | ||
|
||
| ; CHECK-DAG: %[[#uint_16:]] = OpTypeInt 16 0 | ||
| ; CHECK-DAG: %[[#v4uint_16:]] = OpTypeVector %[[#uint_16]] 4 | ||
| ; CHECK-DAG: %[[#v4half:]] = OpTypeVector %[[#half]] 4 | ||
|
|
||
| define i16 @test_half(half nofpclass(nan inf) %p0) { | ||
| entry: | ||
| %0 = bitcast half %p0 to i16 | ||
| ret i16 %0 | ||
|
|
||
| ; CHECK: %[[#arg0:]] = OpFunctionParameter %[[#half]] | ||
| ; CHECK: %[[#bit_cast:]] = OpBitcast %[[#uint_16]] %[[#arg0]] | ||
| ; CHECK: OpReturnValue %[[#bit_cast]] | ||
| } | ||
|
|
||
| define noundef <4 x i16> @test_vector_half(<4 x half> nofpclass(nan inf) %p1) { | ||
| entry: | ||
| %0 = bitcast <4 x half> %p1 to <4 x i16> | ||
| ret <4 x i16> %0 | ||
|
|
||
| ; CHECK: %[[#arg0:]] = OpFunctionParameter %[[#v4half]] | ||
| ; CHECK: %[[#bit_cast:]] = OpBitcast %[[#v4uint_16]] %[[#arg0]] | ||
| ; CHECK: OpReturnValue %[[#bit_cast]] | ||
| } | ||
|
|
||
| attributes #0 = { alwaysinline mustprogress nofree norecurse nosync nounwind willreturn memory(none) "approx-func-fp-math"="true" "no-infs-fp-math"="true" "no-nans-fp-math"="true" "no-signed-zeros-fp-math"="true" "no-trapping-math"="true" "stack-protector-buffer-size"="8" } | ||
|
|
||
| !llvm.module.flags = !{!0} | ||
| !dx.valver = !{!1} | ||
| !llvm.ident = !{!2} | ||
|
|
||
| !0 = !{i32 1, !"wchar_size", i32 4} | ||
| !1 = !{i32 1, i32 8} | ||
| !2 = !{!"clang version 21.0.0git (https://github.com/llvm/llvm-project.git 8037234c865d98219b54a70d9d63aee1d1f2be1c)"} | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to add the Shader Model 6.2 availability macro to these two functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added suggested shader model macro.