From 4d69301ac77902489dd00adeba6d4dfe3cf75413 Mon Sep 17 00:00:00 2001 From: Paul Date: Sat, 22 Mar 2025 22:31:21 +0100 Subject: [PATCH 1/3] get rid off temporary (maybe_unused) --- .../time.clock/time.clock.gps/types.compile.pass.cpp | 11 +++++------ .../time.clock/time.clock.tai/types.compile.pass.cpp | 11 +++++------ .../time.clock/time.clock.utc/types.compile.pass.cpp | 11 +++++------ 3 files changed, 15 insertions(+), 18 deletions(-) diff --git a/libcxx/test/std/time/time.clock/time.clock.gps/types.compile.pass.cpp b/libcxx/test/std/time/time.clock/time.clock.gps/types.compile.pass.cpp index 006ad9a2d243e..81604b6e8be7f 100644 --- a/libcxx/test/std/time/time.clock/time.clock.gps/types.compile.pass.cpp +++ b/libcxx/test/std/time/time.clock/time.clock.gps/types.compile.pass.cpp @@ -36,11 +36,10 @@ #include "test_macros.h" // class gps_clock -using rep = std::chrono::gps_clock::rep; -using period = std::chrono::gps_clock::period; -using duration = std::chrono::gps_clock::duration; -using time_point = std::chrono::gps_clock::time_point; -[[maybe_unused]] constexpr bool is_steady = std::chrono::gps_clock::is_steady; +using rep = std::chrono::gps_clock::rep; +using period = std::chrono::gps_clock::period; +using duration = std::chrono::gps_clock::duration; +using time_point = std::chrono::gps_clock::time_point; // Tests the values. part of them are implementation defined. LIBCPP_STATIC_ASSERT(std::same_as); @@ -52,7 +51,7 @@ static_assert(std::same_as>); static_assert(std::same_as>); static_assert(std::same_as>); -LIBCPP_STATIC_ASSERT(is_steady == false); +LIBCPP_STATIC_ASSERT(std::chrono::gps_clock::is_steady == false); // typedefs static_assert(std::same_as, std::chrono::time_point>); diff --git a/libcxx/test/std/time/time.clock/time.clock.tai/types.compile.pass.cpp b/libcxx/test/std/time/time.clock/time.clock.tai/types.compile.pass.cpp index a7123bc3e0b5c..b411b1a13acf6 100644 --- a/libcxx/test/std/time/time.clock/time.clock.tai/types.compile.pass.cpp +++ b/libcxx/test/std/time/time.clock/time.clock.tai/types.compile.pass.cpp @@ -36,11 +36,10 @@ #include "test_macros.h" // class tai_clock -using rep = std::chrono::tai_clock::rep; -using period = std::chrono::tai_clock::period; -using duration = std::chrono::tai_clock::duration; -using time_point = std::chrono::tai_clock::time_point; -[[maybe_unused]] constexpr bool is_steady = std::chrono::tai_clock::is_steady; +using rep = std::chrono::tai_clock::rep; +using period = std::chrono::tai_clock::period; +using duration = std::chrono::tai_clock::duration; +using time_point = std::chrono::tai_clock::time_point; // Tests the values. part of them are implementation defined. LIBCPP_STATIC_ASSERT(std::same_as); @@ -52,7 +51,7 @@ static_assert(std::same_as>); static_assert(std::same_as>); static_assert(std::same_as>); -LIBCPP_STATIC_ASSERT(is_steady == false); +LIBCPP_STATIC_ASSERT(std::chrono::tai_clock::is_steady == false); // typedefs static_assert(std::same_as, std::chrono::time_point>); diff --git a/libcxx/test/std/time/time.clock/time.clock.utc/types.compile.pass.cpp b/libcxx/test/std/time/time.clock/time.clock.utc/types.compile.pass.cpp index 8cb3d78d97f52..292e2c47c02b6 100644 --- a/libcxx/test/std/time/time.clock/time.clock.utc/types.compile.pass.cpp +++ b/libcxx/test/std/time/time.clock/time.clock.utc/types.compile.pass.cpp @@ -36,11 +36,10 @@ #include "test_macros.h" // class utc_clock -using rep = std::chrono::utc_clock::rep; -using period = std::chrono::utc_clock::period; -using duration = std::chrono::utc_clock::duration; -using time_point = std::chrono::utc_clock::time_point; -[[maybe_unused]] constexpr bool is_steady = std::chrono::utc_clock::is_steady; +using rep = std::chrono::utc_clock::rep; +using period = std::chrono::utc_clock::period; +using duration = std::chrono::utc_clock::duration; +using time_point = std::chrono::utc_clock::time_point; // Tests the values. Some of them are implementation-defined. LIBCPP_STATIC_ASSERT(std::same_as); @@ -52,7 +51,7 @@ static_assert(std::same_as>); static_assert(std::same_as>); static_assert(std::same_as>); -LIBCPP_STATIC_ASSERT(is_steady == false); +LIBCPP_STATIC_ASSERT(std::chrono::utc_clock::is_steady == false); // typedefs static_assert(std::same_as, std::chrono::time_point>); From 7fa98a20e864a245c7960e56902294677ee36ee8 Mon Sep 17 00:00:00 2001 From: Paul Date: Sun, 23 Mar 2025 18:01:21 +0100 Subject: [PATCH 2/3] is_steady: testing type and value --- .../std/time/time.clock/time.clock.gps/types.compile.pass.cpp | 4 +++- .../std/time/time.clock/time.clock.tai/types.compile.pass.cpp | 4 +++- .../std/time/time.clock/time.clock.utc/types.compile.pass.cpp | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/libcxx/test/std/time/time.clock/time.clock.gps/types.compile.pass.cpp b/libcxx/test/std/time/time.clock/time.clock.gps/types.compile.pass.cpp index 81604b6e8be7f..7b3b581fbcc77 100644 --- a/libcxx/test/std/time/time.clock/time.clock.gps/types.compile.pass.cpp +++ b/libcxx/test/std/time/time.clock/time.clock.gps/types.compile.pass.cpp @@ -41,6 +41,8 @@ using period = std::chrono::gps_clock::period; using duration = std::chrono::gps_clock::duration; using time_point = std::chrono::gps_clock::time_point; +[[maybe_unused]] constexpr std::same_as decltype(auto) is_steady = std::chrono::gps_clock::is_steady; + // Tests the values. part of them are implementation defined. LIBCPP_STATIC_ASSERT(std::same_as); static_assert(std::is_arithmetic_v); @@ -51,7 +53,7 @@ static_assert(std::same_as>); static_assert(std::same_as>); static_assert(std::same_as>); -LIBCPP_STATIC_ASSERT(std::chrono::gps_clock::is_steady == false); +LIBCPP_STATIC_ASSERT(is_steady == false); // typedefs static_assert(std::same_as, std::chrono::time_point>); diff --git a/libcxx/test/std/time/time.clock/time.clock.tai/types.compile.pass.cpp b/libcxx/test/std/time/time.clock/time.clock.tai/types.compile.pass.cpp index b411b1a13acf6..e7d2a2e8dc477 100644 --- a/libcxx/test/std/time/time.clock/time.clock.tai/types.compile.pass.cpp +++ b/libcxx/test/std/time/time.clock/time.clock.tai/types.compile.pass.cpp @@ -41,6 +41,8 @@ using period = std::chrono::tai_clock::period; using duration = std::chrono::tai_clock::duration; using time_point = std::chrono::tai_clock::time_point; +[[maybe_unused]] constexpr std::same_as decltype(auto) is_steady = std::chrono::tai_clock::is_steady; + // Tests the values. part of them are implementation defined. LIBCPP_STATIC_ASSERT(std::same_as); static_assert(std::is_arithmetic_v); @@ -51,7 +53,7 @@ static_assert(std::same_as>); static_assert(std::same_as>); static_assert(std::same_as>); -LIBCPP_STATIC_ASSERT(std::chrono::tai_clock::is_steady == false); +LIBCPP_STATIC_ASSERT(is_steady == false); // typedefs static_assert(std::same_as, std::chrono::time_point>); diff --git a/libcxx/test/std/time/time.clock/time.clock.utc/types.compile.pass.cpp b/libcxx/test/std/time/time.clock/time.clock.utc/types.compile.pass.cpp index 292e2c47c02b6..38d7197ce225e 100644 --- a/libcxx/test/std/time/time.clock/time.clock.utc/types.compile.pass.cpp +++ b/libcxx/test/std/time/time.clock/time.clock.utc/types.compile.pass.cpp @@ -41,6 +41,8 @@ using period = std::chrono::utc_clock::period; using duration = std::chrono::utc_clock::duration; using time_point = std::chrono::utc_clock::time_point; +[[maybe_unused]] constexpr std::same_as decltype(auto) is_steady = std::chrono::utc_clock::is_steady; + // Tests the values. Some of them are implementation-defined. LIBCPP_STATIC_ASSERT(std::same_as); static_assert(std::is_arithmetic_v); @@ -51,7 +53,7 @@ static_assert(std::same_as>); static_assert(std::same_as>); static_assert(std::same_as>); -LIBCPP_STATIC_ASSERT(std::chrono::utc_clock::is_steady == false); +LIBCPP_STATIC_ASSERT(is_steady == false); // typedefs static_assert(std::same_as, std::chrono::time_point>); From d76f438ee60d35dc1f7275b5cf949cc1b3b8cac2 Mon Sep 17 00:00:00 2001 From: Paul Date: Sun, 23 Mar 2025 18:25:30 +0100 Subject: [PATCH 3/3] testing older clock's is_steady type (and optionally value) --- .../std/time/time.clock/time.clock.hires/consistency.pass.cpp | 2 +- .../std/time/time.clock/time.clock.steady/consistency.pass.cpp | 2 +- .../std/time/time.clock/time.clock.system/consistency.pass.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libcxx/test/std/time/time.clock/time.clock.hires/consistency.pass.cpp b/libcxx/test/std/time/time.clock/time.clock.hires/consistency.pass.cpp index ad1bce8963074..6765ffb54b9b2 100644 --- a/libcxx/test/std/time/time.clock/time.clock.hires/consistency.pass.cpp +++ b/libcxx/test/std/time/time.clock/time.clock.hires/consistency.pass.cpp @@ -30,7 +30,7 @@ int main(int, char**) static_assert((std::is_same::value), ""); static_assert((std::is_same::value), ""); static_assert((std::is_same::value), ""); - static_assert(C::is_steady || !C::is_steady, ""); + static_assert(std::is_same::value, ""); test(std::chrono::high_resolution_clock::is_steady); return 0; diff --git a/libcxx/test/std/time/time.clock/time.clock.steady/consistency.pass.cpp b/libcxx/test/std/time/time.clock/time.clock.steady/consistency.pass.cpp index fa0ff4f50db83..fcb0df01a331d 100644 --- a/libcxx/test/std/time/time.clock/time.clock.steady/consistency.pass.cpp +++ b/libcxx/test/std/time/time.clock/time.clock.steady/consistency.pass.cpp @@ -32,7 +32,7 @@ int main(int, char**) static_assert((std::is_same::value), ""); static_assert((std::is_same::value), ""); static_assert((std::is_same::value), ""); - static_assert(C::is_steady, ""); + static_assert(std::is_same::value && C::is_steady, ""); test(std::chrono::steady_clock::is_steady); return 0; diff --git a/libcxx/test/std/time/time.clock/time.clock.system/consistency.pass.cpp b/libcxx/test/std/time/time.clock/time.clock.system/consistency.pass.cpp index 124e9fe41bea0..e9bd175efb240 100644 --- a/libcxx/test/std/time/time.clock/time.clock.system/consistency.pass.cpp +++ b/libcxx/test/std/time/time.clock/time.clock.system/consistency.pass.cpp @@ -31,7 +31,7 @@ int main(int, char**) static_assert((std::is_same::value), ""); static_assert((std::is_same::value), ""); static_assert((std::is_same::value), ""); - static_assert((C::is_steady || !C::is_steady), ""); + static_assert(std::is_same::value, ""); test(std::chrono::system_clock::is_steady); return 0;