From b14ec8092e969a3d2f3f7d27901c79efcd78d698 Mon Sep 17 00:00:00 2001 From: Mohammed Keyvanzadeh Date: Tue, 25 Mar 2025 03:47:46 +0330 Subject: [PATCH] [llvm][ADT] Some AddressRanges.h improvements - Rename parameter to adhere to the project's parameter naming convention. - Remove redundant template argument. - Remove redundant name-qualification. - Change non-explicit conversion operator to an explicit one to avoid surprising implicit conversions. --- llvm/include/llvm/ADT/AddressRanges.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/llvm/include/llvm/ADT/AddressRanges.h b/llvm/include/llvm/ADT/AddressRanges.h index 415d30bbb5cf9..299b89c18b7e9 100644 --- a/llvm/include/llvm/ADT/AddressRanges.h +++ b/llvm/include/llvm/ADT/AddressRanges.h @@ -83,12 +83,12 @@ template class AddressRangesBase { typename Collection::const_iterator begin() const { return Ranges.begin(); } typename Collection::const_iterator end() const { return Ranges.end(); } - const T &operator[](size_t i) const { - assert(i < Ranges.size()); - return Ranges[i]; + const T &operator[](size_t I) const { + assert(I < Ranges.size()); + return Ranges[I]; } - bool operator==(const AddressRangesBase &RHS) const { + bool operator==(const AddressRangesBase &RHS) const { return Ranges == RHS.Ranges; } @@ -124,7 +124,7 @@ class AddressRanges : public AddressRangesBase { if (Range.empty()) return Ranges.end(); - auto It = llvm::upper_bound(Ranges, Range); + auto It = upper_bound(Ranges, Range); auto It2 = It; while (It2 != Ranges.end() && It2->start() <= Range.end()) ++It2; @@ -144,7 +144,7 @@ class AddressRanges : public AddressRangesBase { class AddressRangeValuePair { public: - operator AddressRange() const { return Range; } + explicit operator AddressRange() const { return Range; } AddressRange Range; int64_t Value = 0;