From eeb0d6dd2a01d34ef92ab019246f0fa893954cb8 Mon Sep 17 00:00:00 2001 From: Walter Lee Date: Thu, 27 Mar 2025 18:55:59 -0400 Subject: [PATCH] Revert "Fix gcc signed/unsigned comparison warning. NFC." This reverts commit 6c2171672f03356835c534a0ec18250233ea66db. It touches a common file as #133083, which is causing failures --- llvm/lib/Target/X86/X86ISelLowering.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp index a514e7f1ab48c..81c75a2f98079 100644 --- a/llvm/lib/Target/X86/X86ISelLowering.cpp +++ b/llvm/lib/Target/X86/X86ISelLowering.cpp @@ -58959,7 +58959,7 @@ static SDValue combineINSERT_SUBVECTOR(SDNode *N, SelectionDAG &DAG, // If we're splatting the lower half subvector of a full vector load into the // upper half, attempt to create a subvector broadcast. // TODO: Drop hasOneUse checks. - if ((int)IdxVal == (VecNumElts / 2) && + if (IdxVal == (VecNumElts / 2) && Vec.getValueSizeInBits() == (2 * SubVec.getValueSizeInBits()) && (Vec.hasOneUse() || SubVec.hasOneUse())) { auto *VecLd = dyn_cast(Vec);