Skip to content

Added InvertedFPClassTest in legalizerHelper #133403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sumesh-s-mcw wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Added InvertedFPClassTest in legalizerHelper #133403

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ffc741
FEAT : Added InvertedFPClassTest in LegalizerHelper
sumesh-s-mcw Mar 30, 2025
ba89b42
Removed braces
sumesh-s-mcw Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
//===----------------------------------------------------------------------===//

#include "llvm/CodeGen/GlobalISel/LegalizerHelper.h"
#include "llvm/CodeGen/CodeGenCommonISel.h"
#include "llvm/CodeGen/GlobalISel/CallLowering.h"
#include "llvm/CodeGen/GlobalISel/GISelChangeObserver.h"
#include "llvm/CodeGen/GlobalISel/GISelValueTracking.h"
Expand Down Expand Up @@ -9100,8 +9101,12 @@ LegalizerHelper::lowerISFPCLASS(MachineInstr &MI) {
return Legalized;
}

// TODO: Try inverting the test with getInvertedFPClassTest like the DAG
// version
bool isInverted = false;
FPClassTest InvertedTest = llvm::invertFPClassTestIfSimpler(Mask, false);
if (InvertedTest != fcNone) {
Mask = InvertedTest;
isInverted = true;
}

unsigned BitSize = SrcTy.getScalarSizeInBits();
const fltSemantics &Semantics = getFltSemanticForLLT(SrcTy.getScalarType());
Expand Down Expand Up @@ -9252,7 +9257,9 @@ LegalizerHelper::lowerISFPCLASS(MachineInstr &MI) {
}
appendToRes(NormalRes);
}

if (isInverted) {
Res = MIRBuilder.buildNot(DstTy, Res);
}
Copy link
Contributor

@arsenm arsenm Apr 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need braces

MIRBuilder.buildCopy(DstReg, Res);
MI.eraseFromParent();
return Legalized;
Expand Down