Skip to content

Conversation

@topperc
Copy link
Collaborator

@topperc topperc commented Mar 28, 2025

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Mar 28, 2025

@llvm/pr-subscribers-backend-risc-v

Author: Craig Topper (topperc)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/133514.diff

1 Files Affected:

  • (modified) llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp (+1-2)
diff --git a/llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp b/llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp
index e2a98e8bbbf4e..28c0623776977 100644
--- a/llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp
+++ b/llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp
@@ -455,8 +455,7 @@ static DecodeStatus decodeCLUIImmOperand(MCInst &Inst, uint32_t Imm,
   assert(isUInt<6>(Imm) && "Invalid immediate");
   if (Imm == 0)
     return MCDisassembler::Fail;
-  if (Imm > 31)
-    Imm = (SignExtend64<6>(Imm) & 0xfffff);
+  Imm = SignExtend64<6>(Imm) & 0xfffff;
   Inst.addOperand(MCOperand::createImm(Imm));
   return MCDisassembler::Success;
 }

@topperc
Copy link
Collaborator Author

topperc commented Mar 28, 2025

CC: @paulhuggett

@paulhuggett
Copy link
Contributor

I tried adding an assertion to verify that this test has no effect. It did not trip despite the c_lui_disasm.txt exercising all possible inputs. LGTM.

@topperc topperc merged commit 973bf4d into llvm:main Mar 28, 2025
13 checks passed
@topperc topperc deleted the pr/clui-ext branch March 28, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants