Skip to content

Conversation

@fmayer
Copy link
Contributor

@fmayer fmayer commented Mar 28, 2025

it seems the %run was accidentally omitted, otherwise the assert calls
would not make sense

Created using spr 1.3.4
@llvmbot
Copy link
Member

llvmbot commented Mar 28, 2025

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Florian Mayer (fmayer)

Changes

it seems the %run was accidentally omitted, otherwise the assert calls
would not make sense


Full diff: https://github.com/llvm/llvm-project/pull/133529.diff

1 Files Affected:

  • (modified) compiler-rt/test/sanitizer_common/TestCases/Linux/preadv2.cpp (+1-1)
diff --git a/compiler-rt/test/sanitizer_common/TestCases/Linux/preadv2.cpp b/compiler-rt/test/sanitizer_common/TestCases/Linux/preadv2.cpp
index 4ec6f9f69078a..11760d3c1bb42 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/Linux/preadv2.cpp
+++ b/compiler-rt/test/sanitizer_common/TestCases/Linux/preadv2.cpp
@@ -1,4 +1,4 @@
-// RUN: %clangxx -O0 %s -o %t
+// RUN: %clangxx -O0 %s -o %t && %run %t
 
 // REQUIRES: glibc
 

@fmayer fmayer requested a review from devnexen March 28, 2025 22:30
@fmayer fmayer merged commit 1e00bb1 into main Mar 28, 2025
13 checks passed
@fmayer fmayer deleted the users/fmayer/spr/sanitizer-actually-run-preadv2-test branch March 28, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants