[DirectX] Fix build break caused by bitcode writer changes #133770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: llvm@6894734 added a new `writeDIFixedPointType` function. However DIFixedPointType is not supported in DXIL so we need to add a fail fast case for this to fix the build. this change fixes a build break introduced by llvm#129596
Member
|
@llvm/pr-subscribers-backend-directx Author: Farzon Lotfi (farzonl) Changescommit: 6894734 added a new this change fixes a build break introduced by #129596 Full diff: https://github.com/llvm/llvm-project/pull/133770.diff 1 Files Affected:
diff --git a/llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp b/llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp
index ea33ee5759cb7..2a736c91c05c7 100644
--- a/llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp
+++ b/llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp
@@ -237,6 +237,11 @@ class DXILBitcodeWriter {
SmallVectorImpl<uint64_t> &Record, unsigned Abbrev);
void writeDIBasicType(const DIBasicType *N, SmallVectorImpl<uint64_t> &Record,
unsigned Abbrev);
+ void writeDIFixedPointType(const DIFixedPointType *N,
+ SmallVectorImpl<uint64_t> &Record,
+ unsigned Abbrev) {
+ llvm_unreachable("DXIL cannot contain DIFixedPointType Nodes");
+ }
void writeDIStringType(const DIStringType *N,
SmallVectorImpl<uint64_t> &Record, unsigned Abbrev) {
llvm_unreachable("DXIL cannot contain DIStringType Nodes");
|
spall
approved these changes
Mar 31, 2025
bogner
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit: 6894734 added a new
writeDIFixedPointTypefunction.However,
DIFixedPointTypeis not supported in DXIL so we need to add a fail fast case for this to fix the build.this change fixes a build break introduced by #129596