Skip to content

[lldb-dap] Do not take ownership of stdin. #133811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025
Merged

[lldb-dap] Do not take ownership of stdin. #133811

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9053618
[lldb-dap] Do not take ownership of stdin.
ashgti Mar 31, 2025
c695e60
Using `NativeFile::Unowned` instead of `false`.
ashgti Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lldb/tools/lldb-dap/lldb-dap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ int main(int argc, char *argv[]) {
}

lldb::IOObjectSP input = std::make_shared<NativeFile>(
fileno(stdin), File::eOpenOptionReadOnly, true);
fileno(stdin), File::eOpenOptionReadOnly, false);
lldb::IOObjectSP output = std::make_shared<NativeFile>(
stdout_fd, File::eOpenOptionWriteOnly, false);

Expand Down
Loading