[compiler-rt] Fix addtf3_test.c being skipped due to misplaced include
#134106
Conversation
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
The test `addtf3_test.c` is currently guarded by `#if defined(CRT_HAS_IEEE_TF)`, a macro that is declared in `int_lib.h`. However, `int_lib.h` is included *after* the preprocessor check, which results in the macro not being defined in time and causes the test to always be skipped. This patch moves the includes of `fp_test.h` and `int_lib.h` to the top of the file so that `CRT_HAS_IEEE_TF` is defined before it is checked.
Sunday111
force-pushed
the
fix-test-compiler-rt
branch
from
cdb9952 to
2b140e9
Compare
|
Hello @pranavk, could you please take a look at this? |
pranavk
left a comment
pranavk
left a comment
There was a problem hiding this comment.
I didn't verify the new hexadecimal uint64 hi and lo numbers but assuming they are correct, LGTM
|
Hello @pranavk . Thank you for your approval. |
|
@Sunday111 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
3 participants
[compiler-rt] The test
addtf3_test.cis currently guarded by#if defined(CRT_HAS_IEEE_TF), a macro that is declared inint_lib.h. However,int_lib.his included after the preprocessor check, which results in the macro not being defined in time and causes the test to always be skipped.This patch moves the includes of
fp_test.handint_lib.hto the top of the file so thatCRT_HAS_IEEE_TFis defined before it is checked.