Skip to content

[NFC] Fixes proposed by code sanitizer. #134138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zahiraam merged 5 commits into from
Apr 4, 2025
Merged

[NFC] Fixes proposed by code sanitizer. #134138

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
608f582
[NFC] Fixes proposed by code sanitizer.
zahiraam Apr 2, 2025
5f453eb
Removed added file.
zahiraam Apr 2, 2025
0ab8d53
Merge branch 'main' into SanitizerFixes
zahiraam Apr 3, 2025
c9bfb44
Added the & at line 315 of Headers.cpp.
zahiraam Apr 3, 2025
c51acef
Removed the potential antipattern in clang-tidy.
zahiraam Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ static IntegerRange createFromType(const ASTContext &Context,
llvm::APSInt LowerValue(PrecisionBits + 2, /*isUnsigned*/ false);
LowerValue.setBit(PrecisionBits);
LowerValue.setSignBit();
return {LowerValue, UpperValue};
return {std::move(LowerValue), UpperValue};
Copy link
Member

@PiotrZSL PiotrZSL Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't have any impact.
And if using move, why not for a second too

Copy link
Contributor

@carlosgalvezp carlosgalvezp Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this actually an antipattern? What exactly do you mean by "code sanitizer", can you show the actual error message?

Copy link
Contributor Author

@zahiraam zahiraam Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the error message:
" LowerValue is passed-by-value as parameter to llvm::APSInt::APSInt(llvm::APSInt const &) /implicit =default/, when it could be moved instead"
"Use std::move(LowerValue) instead of LowerValue."

Copy link
Contributor Author

@zahiraam zahiraam Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this should be reverted?

Copy link
Contributor Author

@zahiraam zahiraam Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't have any impact. And if using move, why not for a second too

Good point. I was only addressing the issues that the sanitizer identified.

Copy link
Contributor

@carlosgalvezp carlosgalvezp Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What tool did you use to get that error message?

I do not see the point of this change, please revert. We must not blindly do what tools tell us, we must critically think if they make sense or not.

}
assert(T.isInteger() && "Unexpected builtin type");
uint64_t TypeSize = Context.getTypeSize(&T);
Expand Down
2 changes: 1 addition & 1 deletion clang-tools-extra/clangd/ConfigCompile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,7 @@ struct FragmentCompiler {
}
if (Filters->empty())
return std::nullopt;
auto Filter = [Filters](llvm::StringRef Path) {
auto Filter = [Filters = std::move(Filters)](llvm::StringRef Path) {
Copy link
Contributor

@nicovank nicovank Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 520: this can now be a make_unique.

for (auto &Regex : *Filters)
Copy link
Contributor

@nicovank nicovank Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for (auto &Regex : *Filters)
for (const auto &Regex : *Filters)

Same for both cases in other file.

if (Regex.match(Path))
return true;
Expand Down
2 changes: 1 addition & 1 deletion clang-tools-extra/clangd/Headers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ IncludeInserter::calculateIncludePath(const HeaderFile &InsertedHeader,
if (llvm::sys::path::is_absolute(Suggested))
return std::nullopt;
bool IsAngled = false;
for (auto Filter : AngledHeaders) {
for (auto &Filter : AngledHeaders) {
Copy link
Member

@PiotrZSL PiotrZSL Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same thing in line 315

if (Filter(Suggested)) {
IsAngled = true;
break;
Expand Down
Loading