Skip to content

[IR] Deprecate PointerType::get/getUnqual pointee type overload #134517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2025
Merged

[IR] Deprecate PointerType::get/getUnqual pointee type overload #134517

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58d92f5
[IR] Deprecate PointerType::get/getUnqual pointee type overload
junlarsen Mar 31, 2025
b3c03d6
Use [[deprecated]] attribute instead
junlarsen Apr 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions llvm/include/llvm/IR/DerivedTypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,13 +685,19 @@ class PointerType : public Type {

/// This constructs a pointer to an object of the specified type in a numbered
/// address space.
LLVM_DEPRECATED("PointerType::get with pointee type is pending removal. Use "
"Context overload.",
"PointerType::get(LLVMContext, AS)")
Copy link
Contributor

@nikic nikic Apr 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use [[deprecated]] instead. Only use LLVM_DEPRECATED if you can actually provide a working fixit, which you can't do here.

Copy link
Member Author

@junlarsen junlarsen Apr 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up! Taken care of in b3c03d6

static PointerType *get(Type *ElementType, unsigned AddressSpace);
/// This constructs an opaque pointer to an object in a numbered address
/// space.
static PointerType *get(LLVMContext &C, unsigned AddressSpace);

/// This constructs a pointer to an object of the specified type in the
/// default address space (address space zero).
LLVM_DEPRECATED("PointerType::getUnqual with pointee type is pending "
"removal. Use Context overload.",
"PointerType::getUnqual(LLVMCOntext)")
static PointerType *getUnqual(Type *ElementType) {
return PointerType::get(ElementType, 0);
Copy link
Collaborator

@RKSimon RKSimon Apr 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@junlarsen MSVC is warning because this is calling the now deprecated llvm.PointerType.get() variant - would it be possible for you to update this to call the LLVMContext variant directly to silence the warning and allow us to re-enable Werror builds please?

Copy link
Member Author

@junlarsen junlarsen Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll do that.

}
Expand Down