-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[llvm] add documentation for public interface annotations (LLVM_ABI, etc) #134710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9149044 to
01ce75b
Compare
|
This write-up is based on my exercise of annotating most of the LLVM codebase, and I think it is worth merging it prior to merging more annotations. |
24584fa to
85bdcd8
Compare
85bdcd8 to
5272f5d
Compare
|
I can list some edge cases that might be worth including in some way:
|
Thank you for these, @fsfod! That's valuable info, and I have not yet encountered these problems myself. I will create an addendum at the end of the doc to call-out these edge cases. |
|
Thanks @compnerd, @vgvassilev, and @fsfod for the great feedback on this. I've made additions and improvements based on your input. I have one more change to make: I will incorporate @fsfod's list of edge cases at the end of the doc after I've tested them out. |
Co-authored-by: Saleem Abdulrasool <[email protected]>
Co-authored-by: Saleem Abdulrasool <[email protected]>
Co-authored-by: Saleem Abdulrasool <[email protected]>
|
Thanks for adding the docs! |
Purpose
Add documentation for the existing family of
LLVM_ABIannotation macros defined in llvm/Support/Compiler.h. These annotations are used to describe LLVM's public interface.Background
This documentation is in support of the annotation effort described here.
Validation
Manually inspected rendered ReST document on GitHub.