Skip to content

[CodeGen][LLVM] Fix MachineOperand::print crash when TII is nullptr. #135170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

[CodeGen][LLVM] Fix MachineOperand::print crash when TII is nullptr. #135170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions llvm/lib/CodeGen/MachineOperand.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1232,13 +1232,17 @@ void MachineMemOperand::print(raw_ostream &OS, ModuleSlotTracker &MST,
OS, cast<ExternalSymbolPseudoSourceValue>(PVal)->getSymbol());
break;
default: {
const MIRFormatter *Formatter = TII->getMIRFormatter();
// FIXME: This is not necessarily the correct MIR serialization format for
// a custom pseudo source value, but at least it allows
// MIR printing to work on a target with custom pseudo source
// values.
OS << "custom \"";
Formatter->printCustomPseudoSourceValue(OS, MST, *PVal);
if (TII) {
const MIRFormatter *Formatter = TII->getMIRFormatter();
Formatter->printCustomPseudoSourceValue(OS, MST, *PVal);
} else {
PVal->printCustom(OS);
}
OS << '\"';
break;
}
Expand Down