Skip to content

[mlir][vector] Prevent folding non memref-type gather into maskedload #135371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2025
Merged

[mlir][vector] Prevent folding non memref-type gather into maskedload #135371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34b56da
[mlir][vector] Prevent folding non memref-type gather into maskedload
sagar-rain Apr 11, 2025
7d58b14
Merge branch 'main' into fix-fold-contiguous-gather-pattern
sagarkulkarni19 Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mlir/lib/Dialect/Vector/IR/VectorOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5348,6 +5348,9 @@ class FoldContiguousGather final : public OpRewritePattern<GatherOp> {
using OpRewritePattern::OpRewritePattern;
LogicalResult matchAndRewrite(GatherOp op,
PatternRewriter &rewriter) const override {
if (!op.getBase().getType().isa<MemRefType>())
return rewriter.notifyMatchFailure(op, "base must be of memref type");

if (failed(isZeroBasedContiguousSeq(op.getIndexVec())))
return failure();

Expand Down
13 changes: 13 additions & 0 deletions mlir/test/Dialect/Vector/canonicalize.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3198,6 +3198,19 @@ func.func @contiguous_gather_step(%base: memref<?xf32>,

// -----

// CHECK-LABEL: @no_fold_contiguous_gather_tensor
func.func @no_fold_contiguous_gather_tensor(%base: tensor<8xf32>, %mask: vector<4xi1>, %pass_thru: vector<4xf32>) -> vector<4xf32> {
%c0 = arith.constant 0 : index
%indices = arith.constant dense<[0, 1, 2, 3]> : vector<4xindex>
// CHECK: vector.gather
// CHECK-NOT: vector.maskedload
%0 = vector.gather %base[%c0][%indices], %mask, %pass_thru :
tensor<8xf32>, vector<4xindex>, vector<4xi1>, vector<4xf32> into vector<4xf32>
return %0 : vector<4xf32>
}

// -----

// CHECK-LABEL: @gather_broadcast(
// TODO: Broadcast is not supported yet
// CHECK: %[[R:.*]] = vector.gather
Expand Down