[NFC][Clang] Don't check hardcode op num #135375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The num will change for any downstream customization.
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang-modules Author: Jinsong Ji (jsji) ChangesThe num will change for any downstream customization. Full diff: https://github.com/llvm/llvm-project/pull/135375.diff 1 Files Affected:
diff --git a/clang/test/Modules/no-external-type-id.cppm b/clang/test/Modules/no-external-type-id.cppm
index d067e574e72e3..2c05769e4f082 100644
--- a/clang/test/Modules/no-external-type-id.cppm
+++ b/clang/test/Modules/no-external-type-id.cppm
@@ -23,7 +23,7 @@ export module b;
import a;
export int b();
-// CHECK: <DECL_FUNCTION {{.*}} op8=4120
+// CHECK: <DECL_FUNCTION {{.*}} op8=[[#]]
// CHECK: <TYPE_FUNCTION_PROTO
//--- a.v1.cppm
|
Member
|
@llvm/pr-subscribers-clang Author: Jinsong Ji (jsji) ChangesThe num will change for any downstream customization. Full diff: https://github.com/llvm/llvm-project/pull/135375.diff 1 Files Affected:
diff --git a/clang/test/Modules/no-external-type-id.cppm b/clang/test/Modules/no-external-type-id.cppm
index d067e574e72e3..2c05769e4f082 100644
--- a/clang/test/Modules/no-external-type-id.cppm
+++ b/clang/test/Modules/no-external-type-id.cppm
@@ -23,7 +23,7 @@ export module b;
import a;
export int b();
-// CHECK: <DECL_FUNCTION {{.*}} op8=4120
+// CHECK: <DECL_FUNCTION {{.*}} op8=[[#]]
// CHECK: <TYPE_FUNCTION_PROTO
//--- a.v1.cppm
|
cmc-rep
approved these changes
Apr 11, 2025
Maetveis
approved these changes
Apr 11, 2025
Contributor
|
ping @ChuanqiXu9 can you please review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The num will change for any downstream customization.