[libc++] Enable the GDB pretty printers for Clang #135484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Nikolas Klauser (philnik777) ChangesThe GDB pretty printer test works just fine with Clang in the CI now, except that it breaks (not exactly unexpectedly) with optimizations enabled. Full diff: https://github.com/llvm/llvm-project/pull/135484.diff 1 Files Affected:
diff --git a/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp b/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp
index dcdce261298c1..d82842fd5ad5c 100644
--- a/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp
+++ b/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp
@@ -8,12 +8,10 @@
// REQUIRES: host-has-gdb-with-python
// REQUIRES: locale.en_US.UTF-8
+// REQUIRES: optimization=none
// UNSUPPORTED: no-localization
// UNSUPPORTED: c++03
-// TODO: Investigate these failures which break the CI.
-// UNSUPPORTED: clang-18, clang-19, clang-20, clang-21
-
// The Android libc++ tests are run on a non-Android host, connected to an
// Android device over adb. gdb needs special support to make this work (e.g.
// gdbclient.py, ndk-gdb.py, gdbserver), and the Android organization doesn't
|
|
@philnik777 Sadly the pretty-printers seem to be failing on the architectures tested in BuildKite. |
philnik777
force-pushed
the
enable_gdb_pretty_printer
branch
from
f4fd8fa to
ab6b344
Compare
ldionne
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GDB pretty printer test works just fine with Clang in the CI now, except that it breaks (not exactly unexpectedly) with optimizations enabled.