[MLIR] Fix build after #131492 #135502
Merged
[MLIR] Fix build after #131492 #135502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After llvm#131492 is appears that linking MLIRAritDialect was missing.
Member
|
@llvm/pr-subscribers-mlir Author: Jan Patrick Lehr (jplehr) ChangesAfter #131492 is appears that linking MLIRAritDialect was missing. Full diff: https://github.com/llvm/llvm-project/pull/135502.diff 1 Files Affected:
diff --git a/mlir/lib/Target/SMTLIB/CMakeLists.txt b/mlir/lib/Target/SMTLIB/CMakeLists.txt
index 1fd965551ae47..08e2533058a2f 100644
--- a/mlir/lib/Target/SMTLIB/CMakeLists.txt
+++ b/mlir/lib/Target/SMTLIB/CMakeLists.txt
@@ -10,4 +10,5 @@ add_mlir_translation_library(MLIRExportSMTLIB
MLIRFuncDialect
MLIRIR
MLIRTranslateLib
+ MLIRArithDialect
)
|
math-fehr
approved these changes
Apr 12, 2025
Contributor
math-fehr
left a comment
math-fehr
left a comment
There was a problem hiding this comment.
Thanks a lot for fixing this!
Contributor
Contributor
Author
|
Ah! Apologies, missed that it was already taken care of. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #131492 is appears that linking MLIRAritDialect was missing.