[CodeGen] Construct SmallVector with ArrayRef (NFC) #135930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that we can drop the call to reserve because the constructor that takes ArrayRef calls append, which in turn calls reserve.
Member
|
@llvm/pr-subscribers-llvm-selectiondag Author: Kazu Hirata (kazutakahirata) ChangesNote that we can drop the call to reserve because the constructor that Full diff: https://github.com/llvm/llvm-project/pull/135930.diff 1 Files Affected:
diff --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
index d72be359867ca..8322d243b5bc3 100644
--- a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
@@ -24741,10 +24741,8 @@ static SDValue combineConcatVectorOfShuffleAndItsOperands(
// We are going to pad the shuffle operands, so any indice, that was picking
// from the second operand, must be adjusted.
- SmallVector<int, 16> AdjustedMask;
- AdjustedMask.reserve(SVN->getMask().size());
+ SmallVector<int, 16> AdjustedMask(SVN->getMask());
assert(SVN->getOperand(1).isUndef() && "Expected unary shuffle!");
- append_range(AdjustedMask, SVN->getMask());
// Identity masks for the operands of the (padded) shuffle.
SmallVector<int, 32> IdentityMask(2 * OpVT.getVectorNumElements());
|
RKSimon
approved these changes
Apr 16, 2025
Collaborator
RKSimon
left a comment
RKSimon
left a comment
There was a problem hiding this comment.
LGTM (I'm assuming the CI break is unrelated)
tgymnich
approved these changes
Apr 16, 2025
kuhar
approved these changes
Apr 16, 2025
kazutakahirata
deleted the
cleanup_001_SmallVector_ArrayRef_llvm_CodeGen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that we can drop the call to reserve because the constructor that
takes ArrayRef calls append, which in turn calls reserve.