Skip to content

[SCF] add debug label for MergeNestedParallelLoops pattern #135980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SCF] add debug label for MergeNestedParallelLoops pattern #135980

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0974e1
[SCF] add debug label for MergeNestedParallelLoops pattern
Apr 16, 2025
b4275ee
change to setDebugName for pattern only
Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mlir/lib/Dialect/SCF/IR/SCF.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3202,9 +3202,9 @@ struct MergeNestedParallelLoops : public OpRewritePattern<ParallelOp> {

void ParallelOp::getCanonicalizationPatterns(RewritePatternSet &results,
MLIRContext *context) {
results
.add<ParallelOpSingleOrZeroIterationDimsFolder, MergeNestedParallelLoops>(
context);
results.add<ParallelOpSingleOrZeroIterationDimsFolder>(context);
results.addWithLabel<MergeNestedParallelLoops>({"MergeNestedParallelLoops"},
context);
Copy link
Collaborator

@joker-eph joker-eph Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a name on the pattern instead of a label here?
A label to identify a single pattern does not seem the intended purpose of labels.

Copy link
Contributor Author

@rscottmanley rscottmanley Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I agree after I dug around some more. I took my guidance from what I read in include/mlir/Transforms/Passes.h which seems to say you can do it both ways:

/// ... Debug labels must be set explicitly on patterns or when adding
/// them with `RewritePatternSet::addWithLabel`. Debug names may be empty, but
/// patterns created with `RewritePattern::create` have their default debug name
/// set to their type name.

Does this suggest you could have individual pattern names and also a label (in this case, like SCFParallelPatterns) at the same time?

}

/// Given the region at `index`, or the parent operation if `index` is None,
Expand Down
Loading