Revert "[Fuchsia] Not building llvm-mt when LIBXML2 is not enabled." #136216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-clang Author: Paul Kirth (ilovepi) ChangesReverts llvm/llvm-project#135877 This is causing some problems on Fuchsia's windows CI. We'll need a different solution to triage other builders. Full diff: https://github.com/llvm/llvm-project/pull/136216.diff 1 Files Affected:
diff --git a/clang/cmake/caches/Fuchsia-stage2.cmake b/clang/cmake/caches/Fuchsia-stage2.cmake
index e10855f5ef31b..99890b8246ad7 100644
--- a/clang/cmake/caches/Fuchsia-stage2.cmake
+++ b/clang/cmake/caches/Fuchsia-stage2.cmake
@@ -459,6 +459,7 @@ set(LLVM_TOOLCHAIN_TOOLS
llvm-libtool-darwin
llvm-lipo
llvm-ml
+ llvm-mt
llvm-nm
llvm-objcopy
llvm-objdump
@@ -480,10 +481,6 @@ set(LLVM_TOOLCHAIN_TOOLS
scan-build-py
CACHE STRING "")
-if (LLVM_ENABLE_LIBXML2)
- list(APPEND LLVM_TOOLCHAIN_TOOLS llvm-mt)
-endif()
-
set(LLVM_Toolchain_DISTRIBUTION_COMPONENTS
bolt
clang
|
mysterymath
approved these changes
Apr 17, 2025
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…lvm#136216) Reverts llvm#135877 This is causing some problems on Fuchsia's windows CI. We'll need a different solution to triage other builders. https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-windows-x64/b8717476961063994817/overview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #135877
This is causing some problems on Fuchsia's windows CI. We'll need a different solution to triage other builders.
https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-windows-x64/b8717476961063994817/overview