Skip to content

[BOLT] Fix the inaccurate profile data check #136278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WangJee wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[BOLT] Fix the inaccurate profile data check #136278

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33f6b28
[BOLT] Fix the inaccurate profile data check
WangJee Apr 18, 2025
4c5413f
[BOLT] Use the isRISCVCall function to determine whether it is auipc+…
WangJee Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions bolt/lib/Core/BinaryFunction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4658,10 +4658,18 @@ MCInst *BinaryFunction::getInstructionAtOffset(uint64_t Offset) {
if (!BB)
return nullptr;

MCInst preInst;
for (MCInst &Inst : *BB) {
constexpr uint32_t InvalidOffset = std::numeric_limits<uint32_t>::max();
if (Offset == BC.MIB->getOffsetWithDefault(Inst, InvalidOffset))
return &Inst;
// If it's a RISCV PseudoCALL - fix it
if (BC.isRISCV() &&
Offset == BC.MIB->getOffsetWithDefault(Inst, InvalidOffset) - 4) {
if (BC.MIB->isRISCVCall(preInst, Inst))
return &Inst;
}
preInst = Inst;
}

if (MCInst *LastInstr = BB->getLastNonPseudoInstr()) {
Expand Down
Loading