Skip to content

[BOLT] Fix the inaccurate profile data check #136278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WangJee wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[BOLT] Fix the inaccurate profile data check #136278

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33f6b28
[BOLT] Fix the inaccurate profile data check
WangJee Apr 18, 2025
4c5413f
[BOLT] Use the isRISCVCall function to determine whether it is auipc+…
WangJee Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bolt/lib/Profile/DataReader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,6 +524,9 @@ float DataReader::evaluateProfileData(BinaryFunction &BF,
// when we identify tail calls, so they are still represented
// by regular branch instructions and we need isBranch() here.
MCInst *Instr = BF.getInstructionAtOffset(BI.From.Offset);
// If it's a RISCV PseudoCALL - fix it
if (!Instr && BC.isRISCV())
Copy link
Contributor

@aaupov aaupov Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use isRISCVCall(const MCInst &First, const MCInst &Second)

Copy link
Contributor Author

@WangJee WangJee Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MCInst *Instr = BF.getInstructionAtOffset(BI.From.Offset);
But if this method is used, the first instruction will return nullptr, and the second instruction can correctly obtain jalr

Copy link
Contributor Author

@WangJee WangJee Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaupov Could you please review the new changes?

Instr = BF.getInstructionAtOffset(BI.From.Offset + 4);
// If it's a prefix - skip it.
if (Instr && BC.MIB->isPrefix(*Instr))
Instr = BF.getInstructionAtOffset(BI.From.Offset + 1);
Expand Down
Loading