diff --git a/mlir/lib/Dialect/Vector/TransformOps/VectorTransformOps.cpp b/mlir/lib/Dialect/Vector/TransformOps/VectorTransformOps.cpp index 12dcf768dd928..adc1dd437326f 100644 --- a/mlir/lib/Dialect/Vector/TransformOps/VectorTransformOps.cpp +++ b/mlir/lib/Dialect/Vector/TransformOps/VectorTransformOps.cpp @@ -67,10 +67,6 @@ void transform::ApplyFoldElementwiseToVectorPatternsOp::populatePatterns( void transform::ApplyVectorReductionToContractPatternsOp::populatePatterns( RewritePatternSet &patterns) { vector::populateVectorReductionToContractPatterns(patterns); - - // TODO: As we now have a dedicated transform for - // `populateSinkVectorOpsPatterns` we can remove it from here. - vector::populateSinkVectorOpsPatterns(patterns); } void transform::ApplyLowerCreateMaskPatternsOp::populatePatterns( diff --git a/mlir/test/Integration/Dialect/Linalg/CPU/ArmSME/matmul.mlir b/mlir/test/Integration/Dialect/Linalg/CPU/ArmSME/matmul.mlir index 29b0bc0c19606..ad7dbb9f7e126 100644 --- a/mlir/test/Integration/Dialect/Linalg/CPU/ArmSME/matmul.mlir +++ b/mlir/test/Integration/Dialect/Linalg/CPU/ArmSME/matmul.mlir @@ -79,6 +79,7 @@ module attributes {transform.with_named_sequence} { transform.apply_patterns.vector.lower_masked_transfers transform.apply_patterns.vector.transfer_permutation_patterns transform.apply_patterns.vector.reduction_to_contract + transform.apply_patterns.vector.sink_ops } : !transform.any_op // Step 5: Lower vector.contract to vector.outerproduct. Also drop unit diff --git a/mlir/test/Integration/Dialect/Linalg/CPU/ArmSME/multi-tile-matmul-mixed-types.mlir b/mlir/test/Integration/Dialect/Linalg/CPU/ArmSME/multi-tile-matmul-mixed-types.mlir index 78815a38612e9..71798a6affbbc 100644 --- a/mlir/test/Integration/Dialect/Linalg/CPU/ArmSME/multi-tile-matmul-mixed-types.mlir +++ b/mlir/test/Integration/Dialect/Linalg/CPU/ArmSME/multi-tile-matmul-mixed-types.mlir @@ -94,6 +94,7 @@ module attributes {transform.with_named_sequence} { transform.apply_patterns.vector.lower_masked_transfers transform.apply_patterns.vector.transfer_permutation_patterns transform.apply_patterns.vector.reduction_to_contract + transform.apply_patterns.vector.sink_ops } : !transform.any_op // Step 5: Lower vector.contract to vector.outerproduct. Also drop unit