diff --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp index b175e35385ec6..f39951b1865ce 100644 --- a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp @@ -5982,7 +5982,10 @@ SDValue DAGCombiner::hoistLogicOpWithSameOpcodeHands(SDNode *N) { LegalTypes && !TLI.isTypeDesirableForOp(LogicOpcode, XVT)) return SDValue(); // logic_op (hand_op X), (hand_op Y) --> hand_op (logic_op X, Y) - SDValue Logic = DAG.getNode(LogicOpcode, DL, XVT, X, Y); + SDNodeFlags LogicFlags; + LogicFlags.setDisjoint(N->getFlags().hasDisjoint() && + ISD::isExtOpcode(HandOpcode)); + SDValue Logic = DAG.getNode(LogicOpcode, DL, XVT, X, Y, LogicFlags); if (HandOpcode == ISD::SIGN_EXTEND_INREG) return DAG.getNode(HandOpcode, DL, VT, Logic, N0.getOperand(1)); return DAG.getNode(HandOpcode, DL, VT, Logic); diff --git a/llvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td b/llvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td index b2c5261ae6c2d..aea125c5348dd 100644 --- a/llvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td +++ b/llvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td @@ -912,6 +912,29 @@ defm : VPatWidenBinarySDNode_VV_VX_WV_WX; defm : VPatWidenBinarySDNode_VV_VX_WV_WX; defm : VPatWidenBinarySDNode_VV_VX_WV_WX; +// DAGCombiner::hoistLogicOpWithSameOpcodeHands may hoist disjoint ors +// to (ext (or disjoint (a, b))) +multiclass VPatWidenOrDisjoint_VV_VX { + foreach vtiToWti = AllWidenableIntVectors in { + defvar vti = vtiToWti.Vti; + defvar wti = vtiToWti.Wti; + let Predicates = !listconcat(GetVTypePredicates.Predicates, + GetVTypePredicates.Predicates) in { + def : Pat<(wti.Vector (extop (vti.Vector (or_is_add vti.RegClass:$rs2, vti.RegClass:$rs1)))), + (!cast(instruction_name#"_VV_"#vti.LMul.MX) + (wti.Vector (IMPLICIT_DEF)), vti.RegClass:$rs2, + vti.RegClass:$rs1, vti.AVL, vti.Log2SEW, TA_MA)>; + def : Pat<(wti.Vector (extop (vti.Vector (or_is_add vti.RegClass:$rs2, (SplatPat (XLenVT GPR:$rs1)))))), + (!cast(instruction_name#"_VX_"#vti.LMul.MX) + (wti.Vector (IMPLICIT_DEF)), vti.RegClass:$rs2, + GPR:$rs1, vti.AVL, vti.Log2SEW, TA_MA)>; + } + } +} +defm : VPatWidenOrDisjoint_VV_VX; +defm : VPatWidenOrDisjoint_VV_VX; +defm : VPatWidenOrDisjoint_VV_VX; + defm : VPatWidenBinarySDNode_VV_VX_WV_WX; defm : VPatWidenBinarySDNode_VV_VX_WV_WX; defm : VPatWidenBinarySDNode_VV_VX_WV_WX; diff --git a/llvm/test/CodeGen/RISCV/rvv/vwadd-sdnode.ll b/llvm/test/CodeGen/RISCV/rvv/vwadd-sdnode.ll index 3f5d42f89337b..f94e46771f49c 100644 --- a/llvm/test/CodeGen/RISCV/rvv/vwadd-sdnode.ll +++ b/llvm/test/CodeGen/RISCV/rvv/vwadd-sdnode.ll @@ -1417,15 +1417,12 @@ define @vwaddu_vv_disjoint_or_add( %x.i8, %add } -; TODO: We could select vwaddu.vv, but when both arms of the or are the same -; DAGCombiner::hoistLogicOpWithSameOpcodeHands moves the zext above the or. define @vwaddu_vv_disjoint_or( %x.i16, %y.i16) { ; CHECK-LABEL: vwaddu_vv_disjoint_or: ; CHECK: # %bb.0: ; CHECK-NEXT: vsetvli a0, zero, e16, mf2, ta, ma -; CHECK-NEXT: vor.vv v9, v8, v9 -; CHECK-NEXT: vsetvli zero, zero, e32, m1, ta, ma -; CHECK-NEXT: vzext.vf2 v8, v9 +; CHECK-NEXT: vwaddu.vv v10, v8, v9 +; CHECK-NEXT: vmv1r.v v8, v10 ; CHECK-NEXT: ret %x.i32 = zext %x.i16 to %y.i32 = zext %y.i16 to @@ -1433,15 +1430,12 @@ define @vwaddu_vv_disjoint_or( %x.i16, %or } -; TODO: We could select vwadd.vv, but when both arms of the or are the same -; DAGCombiner::hoistLogicOpWithSameOpcodeHands moves the zext above the or. define @vwadd_vv_disjoint_or( %x.i16, %y.i16) { ; CHECK-LABEL: vwadd_vv_disjoint_or: ; CHECK: # %bb.0: ; CHECK-NEXT: vsetvli a0, zero, e16, mf2, ta, ma -; CHECK-NEXT: vor.vv v9, v8, v9 -; CHECK-NEXT: vsetvli zero, zero, e32, m1, ta, ma -; CHECK-NEXT: vsext.vf2 v8, v9 +; CHECK-NEXT: vwadd.vv v10, v8, v9 +; CHECK-NEXT: vmv1r.v v8, v10 ; CHECK-NEXT: ret %x.i32 = sext %x.i16 to %y.i32 = sext %y.i16 to @@ -1449,6 +1443,36 @@ define @vwadd_vv_disjoint_or( %x.i16, %or } +define @vwaddu_vx_disjoint_or( %x.i16, i16 %y.i16) { +; CHECK-LABEL: vwaddu_vx_disjoint_or: +; CHECK: # %bb.0: +; CHECK-NEXT: vsetvli a1, zero, e16, mf2, ta, ma +; CHECK-NEXT: vwaddu.vx v9, v8, a0 +; CHECK-NEXT: vmv1r.v v8, v9 +; CHECK-NEXT: ret + %x.i32 = zext %x.i16 to + %y.head = insertelement poison, i16 %y.i16, i32 0 + %y.splat = shufflevector %y.head, poison, zeroinitializer + %y.i32 = zext %y.splat to + %or = or disjoint %x.i32, %y.i32 + ret %or +} + +define @vwadd_vx_disjoint_or( %x.i16, i16 %y.i16) { +; CHECK-LABEL: vwadd_vx_disjoint_or: +; CHECK: # %bb.0: +; CHECK-NEXT: vsetvli a1, zero, e16, mf2, ta, ma +; CHECK-NEXT: vwadd.vx v9, v8, a0 +; CHECK-NEXT: vmv1r.v v8, v9 +; CHECK-NEXT: ret + %x.i32 = sext %x.i16 to + %y.head = insertelement poison, i16 %y.i16, i32 0 + %y.splat = shufflevector %y.head, poison, zeroinitializer + %y.i32 = sext %y.splat to + %or = or disjoint %x.i32, %y.i32 + ret %or +} + define @vwaddu_wv_disjoint_or( %x.i32, %y.i16) { ; CHECK-LABEL: vwaddu_wv_disjoint_or: ; CHECK: # %bb.0: