Skip to content

[BOLT][test] Resolve symlink for nm tool (NFC) #136722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
+2 −1
Merged

[BOLT][test] Resolve symlink for nm tool (NFC) #136722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bolt/test/link_fdata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

import argparse
import os
import shutil
import subprocess
import sys
import re
Expand Down Expand Up @@ -85,7 +86,7 @@
exit("ERROR: unexpected input:\n%s" % line)

# Read nm output: <symbol value> <symbol type> <symbol name>
is_llvm_nm = os.path.basename(args.nmtool) == "llvm-nm"
is_llvm_nm = os.path.basename(os.path.realpath(shutil.which(args.nmtool))) == "llvm-nm"
Copy link
Contributor

@aaupov aaupov Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need which to handle shell aliases?

Copy link
Contributor Author

@yozhu yozhu Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alias is handled by realpath(). which() is to get the absolute path of nm, which is then passed to realpath() to get the actual target if it is a symlink.

nm_output = subprocess.run(
[
args.nmtool,
Expand Down
Loading