Skip to content

[libc] lfind_test.cpp: put helpers in an anonymous namespace. #137821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2025
Merged

[libc] lfind_test.cpp: put helpers in an anonymous namespace. #137821

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a252b6
lfind_test.cpp: put helpers in an anonymous namespace.
enh-google Apr 29, 2025
979445f
Update lfind_test.cpp
enh-google Apr 29, 2025
a05528f
// namespace
enh-google Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions libc/test/src/search/lfind_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,14 @@
#include "src/search/lfind.h"
#include "test/UnitTest/Test.h"

namespace {

int compar(const void *a, const void *b) {
return *reinterpret_cast<const int *>(a) != *reinterpret_cast<const int *>(b);
}

}

Copy link
Contributor

@jhuber6 jhuber6 Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
namespace {
int compar(const void *a, const void *b) {
return *reinterpret_cast<const int *>(a) != *reinterpret_cast<const int *>(b);
}
}
static int compar(const void *a, const void *b) {
return *reinterpret_cast<const int *>(a) != *reinterpret_cast<const int *>(b);
}

Honestly, this is more in-line with LLVM's coding style, but I don't know how much libc differs.

Copy link
Contributor Author

@enh-google enh-google Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, i'd have just used static myself but other llvm-libc tests seemed to have an anonymous namespace...

TEST(LlvmLibcLfindTest, SearchHead) {
int list[3] = {1, 2, 3};
size_t len = 3;
Expand Down
Loading