Skip to content

Conversation

@Prabhuk
Copy link
Contributor

@Prabhuk Prabhuk commented Apr 29, 2025

There is no support for shared libraries for UEFI target. Remove the
incorrect -dll flag set from UEFI toolchain.

There is no support for shared libraries for UEFI target. Remove the
incorrect -dll flag set from UEFI toolchain.
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' labels Apr 29, 2025
@Prabhuk Prabhuk requested a review from petrhosek April 29, 2025 20:23
@llvmbot
Copy link
Member

llvmbot commented Apr 29, 2025

@llvm/pr-subscribers-clang-driver

@llvm/pr-subscribers-clang

Author: Prabhu Rajasekaran (Prabhuk)

Changes

There is no support for shared libraries for UEFI target. Remove the
incorrect -dll flag set from UEFI toolchain.


Full diff: https://github.com/llvm/llvm-project/pull/137872.diff

2 Files Affected:

  • (modified) clang/lib/Driver/ToolChains/UEFI.cpp (-3)
  • (modified) clang/test/Driver/uefi-constructed-args.c (-1)
diff --git a/clang/lib/Driver/ToolChains/UEFI.cpp b/clang/lib/Driver/ToolChains/UEFI.cpp
index a9d7e7892c5a6..fbef72e34a3b1 100644
--- a/clang/lib/Driver/ToolChains/UEFI.cpp
+++ b/clang/lib/Driver/ToolChains/UEFI.cpp
@@ -80,9 +80,6 @@ void tools::uefi::Linker::ConstructJob(Compilation &C, const JobAction &JA,
   // "Terminal Service Aware" flag is not needed for UEFI applications.
   CmdArgs.push_back("-tsaware:no");
 
-  // EFI_APPLICATION to be linked as DLL by default.
-  CmdArgs.push_back("-dll");
-
   if (Args.hasArg(options::OPT_g_Group, options::OPT__SLASH_Z7))
     CmdArgs.push_back("-debug");
 
diff --git a/clang/test/Driver/uefi-constructed-args.c b/clang/test/Driver/uefi-constructed-args.c
index 44d2271e0c8ba..49ede47a8953e 100644
--- a/clang/test/Driver/uefi-constructed-args.c
+++ b/clang/test/Driver/uefi-constructed-args.c
@@ -11,5 +11,4 @@
 // CHECK-SAME: "-subsystem:efi_application"
 // CHECK-SAME: "-entry:EfiMain"
 // CHECK-SAME: "-tsaware:no"
-// CHECK-SAME: "-dll"
 // CHECK-SAME: "-debug"

@Prabhuk Prabhuk merged commit 1b1e360 into llvm:main May 1, 2025
11 checks passed
@Prabhuk Prabhuk deleted the nfc_uefi branch May 1, 2025 22:49
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
There is no support for shared libraries for UEFI target. Remove the
incorrect -dll flag set from UEFI toolchain.
GeorgeARM pushed a commit to GeorgeARM/llvm-project that referenced this pull request May 7, 2025
There is no support for shared libraries for UEFI target. Remove the
incorrect -dll flag set from UEFI toolchain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants