Skip to content

Conversation

@thetruestblue
Copy link
Contributor

No description provided.

This is handled as a SIGKILL and can't be intercepted by ASan's signal handler.

rdar://127512190
Just landed the disabling on arm64e and ios. This actually should be marked UNSUPPORTED on all arm64.
@thetruestblue thetruestblue changed the title Zero page Unsupported zero_page_pc on iOS. Apr 29, 2025
@llvmbot
Copy link
Member

llvmbot commented Apr 29, 2025

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: None (thetruestblue)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/137893.diff

1 Files Affected:

  • (modified) compiler-rt/test/asan/TestCases/zero_page_pc.cpp (+3)
diff --git a/compiler-rt/test/asan/TestCases/zero_page_pc.cpp b/compiler-rt/test/asan/TestCases/zero_page_pc.cpp
index 3af4d04a587c2..b5ca23e490591 100644
--- a/compiler-rt/test/asan/TestCases/zero_page_pc.cpp
+++ b/compiler-rt/test/asan/TestCases/zero_page_pc.cpp
@@ -1,6 +1,9 @@
 // Check that ASan correctly detects SEGV on the zero page.
 // RUN: %clangxx_asan %s -o %t && not %run %t 2>&1 | FileCheck %s
 
+// Handled as a codesigning violation and exits with SIGKILL not SEGV
+// UNSUPPORTED: ios
+
 #if defined(_MSC_VER) && !defined(__CLANG__)
 #  define __has_feature(x) 0
 #endif

@thetruestblue thetruestblue merged commit c685355 into llvm:main Apr 29, 2025
4 of 10 checks passed
@github-actions
Copy link

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff HEAD~1 HEAD --extensions cpp -- compiler-rt/test/asan/TestCases/zero_page_pc.cpp
View the diff from clang-format here.
diff --git a/compiler-rt/test/asan/TestCases/zero_page_pc.cpp b/compiler-rt/test/asan/TestCases/zero_page_pc.cpp
index 66396a817..b5ca23e49 100644
--- a/compiler-rt/test/asan/TestCases/zero_page_pc.cpp
+++ b/compiler-rt/test/asan/TestCases/zero_page_pc.cpp
@@ -4,7 +4,6 @@
 // Handled as a codesigning violation and exits with SIGKILL not SEGV
 // UNSUPPORTED: ios
 
-
 #if defined(_MSC_VER) && !defined(__CLANG__)
 #  define __has_feature(x) 0
 #endif

IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
GeorgeARM pushed a commit to GeorgeARM/llvm-project that referenced this pull request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants