[Clang][Cygwin] don't use -Bsymbolic-functions #138217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GNU ld seems to ignore this option, but LLD treats the presence of this unknown option as an error.
Member
|
@llvm/pr-subscribers-clang Author: None (jeremyd2019) ChangesGNU ld seems to ignore this option, but LLD treats the presence of this unknown option as an error. Full diff: https://github.com/llvm/llvm-project/pull/138217.diff 1 Files Affected:
diff --git a/clang/tools/clang-shlib/CMakeLists.txt b/clang/tools/clang-shlib/CMakeLists.txt
index 31484ec49c773..317964de4fb17 100644
--- a/clang/tools/clang-shlib/CMakeLists.txt
+++ b/clang/tools/clang-shlib/CMakeLists.txt
@@ -57,7 +57,7 @@ endif()
# Optimize function calls for default visibility definitions to avoid PLT and
# reduce dynamic relocations.
-if (NOT APPLE AND NOT MINGW AND NOT LLVM_LINKER_IS_SOLARISLD_ILLUMOS)
+if (NOT APPLE AND NOT MINGW AND NOT CYGWIN AND NOT LLVM_LINKER_IS_SOLARISLD_ILLUMOS)
target_link_options(clang-cpp PRIVATE LINKER:-Bsymbolic-functions)
endif()
if (MINGW OR CYGWIN)
|
Contributor
Author
|
@mstorsjo I was going through my patches and found a couple tiny ones that I hadn't submitted yet |
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
GNU ld seems to ignore this option, but LLD treats the presence of this unknown option as an error.
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
GNU ld seems to ignore this option, but LLD treats the presence of this unknown option as an error.
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
May 14, 2025
GNU ld seems to ignore this option, but LLD treats the presence of this unknown option as an error.
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
May 15, 2025
GNU ld seems to ignore this option, but LLD treats the presence of this unknown option as an error.
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
Aug 9, 2025
GNU ld seems to ignore this option, but LLD treats the presence of this unknown option as an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GNU ld seems to ignore this option, but LLD treats the presence of this unknown option as an error.