Skip to content

Conversation

@bjope
Copy link
Collaborator

@bjope bjope commented May 2, 2025

Fix "C++ style comments are not allowed in ISO C90" warnings in some C files.

Fix "C++ style comments are not allowed in ISO C90" warnings in some
C files.
@bjope bjope requested a review from jsji May 2, 2025 09:29
@llvmbot llvmbot added clang Clang issues not falling into any other category llvm:support labels May 2, 2025
@llvmbot
Copy link
Member

llvmbot commented May 2, 2025

@llvm/pr-subscribers-llvm-support

@llvm/pr-subscribers-clang

Author: Björn Pettersson (bjope)

Changes

Fix "C++ style comments are not allowed in ISO C90" warnings in some C files.


Full diff: https://github.com/llvm/llvm-project/pull/138244.diff

2 Files Affected:

  • (modified) clang/tools/c-index-test/c-index-test.c (+1-1)
  • (modified) llvm/include/llvm/Support/AutoConvert.h (+6-4)
diff --git a/clang/tools/c-index-test/c-index-test.c b/clang/tools/c-index-test/c-index-test.c
index 7711df3fd9209..ee4a2f37fbc5d 100644
--- a/clang/tools/c-index-test/c-index-test.c
+++ b/clang/tools/c-index-test/c-index-test.c
@@ -1224,7 +1224,7 @@ static CXString createCXString(const char *CS) {
 static CXString duplicateCXString(const char *CS) {
   CXString Str;
   Str.data = strdup(CS);
-  Str.private_flags = 1; // CXS_Malloc
+  Str.private_flags = 1; /* CXS_Malloc */
   return Str;
 }
 
diff --git a/llvm/include/llvm/Support/AutoConvert.h b/llvm/include/llvm/Support/AutoConvert.h
index 5d6d9394ef1d8..352493e9be25f 100644
--- a/llvm/include/llvm/Support/AutoConvert.h
+++ b/llvm/include/llvm/Support/AutoConvert.h
@@ -55,14 +55,16 @@ std::error_code restorezOSStdHandleAutoConversion(int FD);
 /** \brief Set the tag information for a file descriptor. */
 std::error_code setzOSFileTag(int FD, int CCSID, bool Text);
 
-// Get the the tag ccsid for a file name or a file descriptor.
+/** \brief Get the the tag ccsid for a file name or a file descriptor. */
 ErrorOr<__ccsid_t> getzOSFileTag(const char *FileName, const int FD = -1);
 
-// Query the file tag to determine if it needs conversion to UTF-8 codepage.
+/** \brief Query the file tag to determine if it needs conversion to UTF-8
+ *  codepage.
+ */
 ErrorOr<bool> needzOSConversion(const char *FileName, const int FD = -1);
 
-} // namespace llvm
-#endif // __cplusplus
+} /* namespace llvm */
+#endif /* __cplusplus */
 
 #endif /* __MVS__ */
 

@bjope bjope requested a review from abhina-sree May 2, 2025 09:31
Copy link
Contributor

@abhina-sree abhina-sree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bjope bjope merged commit 0054ab4 into llvm:main May 5, 2025
14 checks passed
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
Fix "C++ style comments are not allowed in ISO C90" warnings in some C
files.
GeorgeARM pushed a commit to GeorgeARM/llvm-project that referenced this pull request May 7, 2025
Fix "C++ style comments are not allowed in ISO C90" warnings in some C
files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang Clang issues not falling into any other category llvm:support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants