Skip to content

Conversation

@slydiman
Copy link
Contributor

@slydiman slydiman commented May 2, 2025

See #138085 for details.

@slydiman slydiman added the lldb label May 2, 2025
@slydiman slydiman requested a review from DavidSpickett May 2, 2025 12:53
@slydiman slydiman requested a review from JDevlieghere as a code owner May 2, 2025 12:53
@llvmbot
Copy link
Member

llvmbot commented May 2, 2025

@llvm/pr-subscribers-lldb

Author: Dmitry Vasilyev (slydiman)

Changes

See #138085 for details.


Full diff: https://github.com/llvm/llvm-project/pull/138263.diff

1 Files Affected:

  • (modified) lldb/test/API/tools/lldb-server/TestLldbGdbServer.py (+4)
diff --git a/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py b/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
index eef157c5f490a..2c328125e3058 100644
--- a/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
+++ b/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
@@ -110,6 +110,8 @@ def test_first_launch_stop_reply_thread_matches_first_qC(self):
         context = self.expect_gdbremote_sequence()
         self.assertEqual(context.get("thread_id_QC"), context.get("thread_id_?"))
 
+    # This test is flaky on Windows. Sometimes returns 'Exception 0x80000003'.
+    @skipIf(oslist=["windows"], bugnumber="github.com/llvm/llvm-project/issues/138085")
     def test_attach_commandline_continue_app_exits(self):
         self.build()
         self.set_inferior_startup_attach()
@@ -303,6 +305,8 @@ def Hg_switches_to_3_threads(self, pass_pid=False):
             self.assertIsNotNone(context.get("thread_id"))
             self.assertEqual(int(context.get("thread_id"), 16), thread)
 
+    # This test is flaky on Windows. Sometimes returns '$E37#af'.
+    @skipIf(oslist=["windows"], bugnumber="github.com/llvm/llvm-project/issues/138085")
     @skipIf(compiler="clang", compiler_version=["<", "11.0"])
     def test_Hg_switches_to_3_threads_launch(self):
         self.build()

Copy link
Collaborator

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slydiman slydiman merged commit ace189b into llvm:main May 2, 2025
13 checks passed
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
GeorgeARM pushed a commit to GeorgeARM/llvm-project that referenced this pull request May 7, 2025
@slydiman slydiman deleted the lldb-disable-flaky-TestLldbGdbServer branch June 23, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants