Skip to content

[clang] Remove "unknown" from availability diags #138610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025
Merged

[clang] Remove "unknown" from availability diags #138610

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d642c83
[clang] Remove "unknown" from availability diags
cyndyishida May 5, 2025
9ee9dd6
Address review comments
cyndyishida May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions clang/lib/AST/DeclBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,11 +695,13 @@ static AvailabilityResult CheckAvailability(ASTContext &Context,
if (!A->getIntroduced().empty() &&
EnclosingVersion < A->getIntroduced()) {
IdentifierInfo *IIEnv = A->getEnvironment();
StringRef TargetEnv =
Context.getTargetInfo().getTriple().getEnvironmentName();
StringRef EnvName = llvm::Triple::getEnvironmentTypeName(
Context.getTargetInfo().getTriple().getEnvironment());
// Matching environment or no environment on attribute
auto &Triple = Context.getTargetInfo().getTriple();
StringRef TargetEnv = Triple.getEnvironmentName();
StringRef EnvName =
Triple.hasEnvironment()
? llvm::Triple::getEnvironmentTypeName(Triple.getEnvironment())
: "";
// Matching environment or no environment on attribute.
if (!IIEnv || (!TargetEnv.empty() && IIEnv->getName() == TargetEnv)) {
if (Message) {
Message->clear();
Expand All @@ -709,7 +711,7 @@ static AvailabilityResult CheckAvailability(ASTContext &Context,
<< EnvName << HintMessage;
}
}
// Non-matching environment or no environment on target
// Non-matching environment or no environment on target.
else {
if (Message) {
Message->clear();
Expand Down