Skip to content

[clang] Deflake the TimeProfile support tests #138613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

[clang] Deflake the TimeProfile support tests #138613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions clang/unittests/Support/TimeProfilerTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,16 @@ std::string buildTraceGraph(StringRef Json) {
bool InsideCurrentEvent =
Event.TimestampBegin >= EventStack.top()->TimestampBegin &&
Event.TimestampEnd <= EventStack.top()->TimestampEnd;

// Presumably due to timer rounding, PerformPendingInstantiations often
// appear to be within the timer interval of the immediately previous
// event group. We always know these events occur at level 1, not level 2,
// in our tests, so pop an event in that case.
if (InsideCurrentEvent && Event.Name == "PerformPendingInstantiations" &&
EventStack.size() == 2) {
InsideCurrentEvent = false;
}

if (!InsideCurrentEvent)
EventStack.pop();
else
Expand Down