Skip to content

[lldb-dap] Re-enable the lldb-dap tests #138791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025
Merged

[lldb-dap] Re-enable the lldb-dap tests #138791

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07d6c2e
[lldb-dap] Re-enable the lldb-dap tests
JDevlieghere May 6, 2025
7b24093
Include the issue URL
JDevlieghere May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lldb/test/API/tools/lldb-dap/attach/TestDAP_attach.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ def spawn_and_wait(program, delay):
process.wait()


@skip
class TestDAP_attach(lldbdap_testcase.DAPTestCaseBase):
def set_and_hit_breakpoint(self, continueToExit=True):
self.dap_server.wait_for_stopped()
Expand Down
1 change: 1 addition & 0 deletions lldb/test/API/tools/lldb-dap/attach/TestDAP_attachByPortNum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import socket


@skip("SBTarget::ConnectRemote is not synchronous")
class TestDAP_attachByPortNum(lldbdap_testcase.DAPTestCaseBase):
default_timeout = 20

Expand Down
3 changes: 1 addition & 2 deletions lldb/test/API/tools/lldb-dap/breakpoint/TestDAP_breakpointLocations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@
import lldbdap_testcase
import os

# DAP tests are flakey, see https://github.com/llvm/llvm-project/issues/137660.
@skip

class TestDAP_breakpointLocations(lldbdap_testcase.DAPTestCaseBase):
def setUp(self):
lldbdap_testcase.DAPTestCaseBase.setUp(self)
Expand Down
3 changes: 1 addition & 2 deletions lldb/test/API/tools/lldb-dap/breakpoint/TestDAP_setBreakpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@
import lldbdap_testcase
import os

# DAP tests are flakey, see https://github.com/llvm/llvm-project/issues/137660.
@skip

class TestDAP_setBreakpoints(lldbdap_testcase.DAPTestCaseBase):
def setUp(self):
lldbdap_testcase.DAPTestCaseBase.setUp(self)
Expand Down
2 changes: 0 additions & 2 deletions lldb/test/API/tools/lldb-dap/commands/TestDAP_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
from lldbsuite.test.decorators import *


# DAP tests are flakey, see https://github.com/llvm/llvm-project/issues/137660.
@skip
class TestDAP_commands(lldbdap_testcase.DAPTestCaseBase):
def test_command_directive_quiet_on_success(self):
program = self.getBuildArtifact("a.out")
Expand Down
3 changes: 1 addition & 2 deletions lldb/test/API/tools/lldb-dap/disassemble/TestDAP_disassemble.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@
import lldbdap_testcase
import os

# DAP tests are flakey, see https://github.com/llvm/llvm-project/issues/137660.
@skip

class TestDAP_disassemble(lldbdap_testcase.DAPTestCaseBase):
@skipIfWindows
def test_disassemble(self):
Expand Down
2 changes: 0 additions & 2 deletions lldb/test/API/tools/lldb-dap/evaluate/TestDAP_evaluate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@
from lldbsuite.test.lldbtest import *


# DAP tests are flakey, see https://github.com/llvm/llvm-project/issues/137660.
@skip
class TestDAP_evaluate(lldbdap_testcase.DAPTestCaseBase):
def assertEvaluate(self, expression, regex):
self.assertRegex(
Expand Down
3 changes: 1 addition & 2 deletions lldb/test/API/tools/lldb-dap/memory/TestDAP_memory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@
import lldbdap_testcase
import os

# DAP tests are flakey, see https://github.com/llvm/llvm-project/issues/137660.
@skip

class TestDAP_memory(lldbdap_testcase.DAPTestCaseBase):
def test_memory_refs_variables(self):
"""
Expand Down
3 changes: 1 addition & 2 deletions lldb/test/API/tools/lldb-dap/variables/TestDAP_variables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ def make_buffer_verify_dict(start_idx, count, offset=0):
verify_dict["[%i]" % (i)] = {"type": "int", "value": str(i + offset)}
return verify_dict

# DAP tests are flakey, see https://github.com/llvm/llvm-project/issues/137660.
@skip

class TestDAP_variables(lldbdap_testcase.DAPTestCaseBase):
def verify_values(self, verify_dict, actual, varref_dict=None, expression=None):
if "equals" in verify_dict:
Expand Down
Loading