Fix build failure in DXILResource.h on newer versions of MSVC #139309
Conversation
llvmbot
added
backend:DirectX
llvm:analysis
|
@llvm/pr-subscribers-llvm-analysis Author: Daniel Paoliello (dpaoliello) ChangesThe change #137258 introduced a build break on newer versions of MSVC: Fix is to add a Full diff: https://github.com/llvm/llvm-project/pull/139309.diff 1 Files Affected:
diff --git a/llvm/include/llvm/Analysis/DXILResource.h b/llvm/include/llvm/Analysis/DXILResource.h
index cfeed5c4ef76f..090b6e77eac00 100644
--- a/llvm/include/llvm/Analysis/DXILResource.h
+++ b/llvm/include/llvm/Analysis/DXILResource.h
@@ -670,6 +670,8 @@ class DXILResourceBindingInfo {
return CBufferSpaces;
case dxil::ResourceClass::Sampler:
return SamplerSpaces;
+ default:
+ llvm_unreachable("Invalid resource class");
}
}
|
|
@llvm/pr-subscribers-backend-directx Author: Daniel Paoliello (dpaoliello) ChangesThe change #137258 introduced a build break on newer versions of MSVC: Fix is to add a Full diff: https://github.com/llvm/llvm-project/pull/139309.diff 1 Files Affected:
diff --git a/llvm/include/llvm/Analysis/DXILResource.h b/llvm/include/llvm/Analysis/DXILResource.h
index cfeed5c4ef76f..090b6e77eac00 100644
--- a/llvm/include/llvm/Analysis/DXILResource.h
+++ b/llvm/include/llvm/Analysis/DXILResource.h
@@ -670,6 +670,8 @@ class DXILResourceBindingInfo {
return CBufferSpaces;
case dxil::ResourceClass::Sampler:
return SamplerSpaces;
+ default:
+ llvm_unreachable("Invalid resource class");
}
}
|
| default: | ||
| llvm_unreachable("Invalid resource class"); |
There was a problem hiding this comment.
This isn't quite right. We should put the llvm_unreachable outside of the switch so that we can still benefit from clang's -Wcovered-switch warnings if dxil::ResourceClass were ever to change.
The change #137258 introduced a build break on newer versions of MSVC:
Fix is to add a
defaultcase that will ICE.