[lldb] Fix term settings completion tests

[emmanuel-ferdman]

PR Summary

Small PR - Several test functions for term-width/height completions had identical names, causing silent overriding. This gives them distinct _width/_height suffixes to ensure all tests run.

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Emmanuel Ferdman (emmanuel-ferdman)

Changes

PR Summary

Small PR - Several test functions for term-width/height completions had identical names, causing silent overriding. This gives them distinct _width/_height suffixes to ensure all tests run.

---

Full diff: https://github.com/llvm/llvm-project/pull/139447.diff

1 Files Affected:

• (modified) lldb/test/API/functionalities/completion/TestCompletion.py (+6-6)

diff --git a/lldb/test/API/functionalities/completion/TestCompletion.py b/lldb/test/API/functionalities/completion/TestCompletion.py
index bf043c795fac6..e7c53729f2090 100644
--- a/lldb/test/API/functionalities/completion/TestCompletion.py
+++ b/lldb/test/API/functionalities/completion/TestCompletion.py
@@ -334,22 +334,22 @@ def test_settings_replace_target_ru(self):
             "settings replace target.ru", "settings replace target.run-args"
         )
 
-    def test_settings_show_term(self):
+    def test_settings_show_term_width(self):
         self.complete_from_to("settings show term-w", "settings show term-width")
 
-    def test_settings_list_term(self):
+    def test_settings_list_term_width(self):
         self.complete_from_to("settings list term-w", "settings list term-width")
 
-    def test_settings_show_term(self):
+    def test_settings_show_term_height(self):
         self.complete_from_to("settings show term-h", "settings show term-height")
 
-    def test_settings_list_term(self):
+    def test_settings_list_term_height(self):
         self.complete_from_to("settings list term-h", "settings list term-height")
 
-    def test_settings_remove_term(self):
+    def test_settings_remove_term_width(self):
         self.complete_from_to("settings remove term-w", "settings remove term-width")
 
-    def test_settings_remove_term(self):
+    def test_settings_remove_term_height(self):
         self.complete_from_to("settings remove term-h", "settings remove term-height")
 
     def test_settings_s(self):

[github-actions]

@emmanuel-ferdman Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!