Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
Original file line number Diff line number Diff line change
Expand Up @@ -1899,6 +1899,7 @@ def LLVM_LLVMFuncOp : LLVM_Op<"func", [
OptionalAttr<BoolAttr>:$no_nans_fp_math,
OptionalAttr<BoolAttr>:$approx_func_fp_math,
OptionalAttr<BoolAttr>:$no_signed_zeros_fp_math,
OptionalAttr<BoolAttr>:$amdgpu_unsafe_fp_atomics,
OptionalAttr<StrAttr>:$denormal_fp_math,
OptionalAttr<StrAttr>:$denormal_fp_math_f32,
OptionalAttr<StrAttr>:$fp_contract,
Expand Down
5 changes: 5 additions & 0 deletions mlir/lib/Target/LLVMIR/ModuleImport.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2140,6 +2140,7 @@ static constexpr std::array kExplicitAttributes{
StringLiteral("aarch64_pstate_sm_body"),
StringLiteral("aarch64_pstate_sm_compatible"),
StringLiteral("aarch64_pstate_sm_enabled"),
StringLiteral("amdgpu-unsafe-fp-atomics"),
StringLiteral("alwaysinline"),
StringLiteral("approx-func-fp-math"),
StringLiteral("convergent"),
Expand Down Expand Up @@ -2318,6 +2319,10 @@ void ModuleImport::processFunctionAttributes(llvm::Function *func,
attr.isStringAttribute())
funcOp.setNoSignedZerosFpMath(attr.getValueAsBool());

if (llvm::Attribute attr = func->getFnAttribute("amdgpu-unsafe-fp-atomics");
attr.isStringAttribute())
funcOp.setAmdgpuUnsafeFpAtomics(attr.getValueAsBool());

if (llvm::Attribute attr = func->getFnAttribute("denormal-fp-math");
attr.isStringAttribute())
funcOp.setDenormalFpMathAttr(
Expand Down
4 changes: 4 additions & 0 deletions mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1496,6 +1496,10 @@ LogicalResult ModuleTranslation::convertOneFunction(LLVMFuncOp func) {
else if (func.getArmPreservesZa())
llvmFunc->addFnAttr("aarch64_preserves_za");

if (auto amdgpuUnsafeFpAtomics = func.getAmdgpuUnsafeFpAtomics())
llvmFunc->addFnAttr("amdgpu-unsafe-fp-atomics",
llvm::toStringRef(*amdgpuUnsafeFpAtomics));

if (auto targetCpu = func.getTargetCpu())
llvmFunc->addFnAttr("target-cpu", *targetCpu);

Expand Down
6 changes: 6 additions & 0 deletions mlir/test/Dialect/LLVMIR/func.mlir
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,12 @@ module {
llvm.return
}

llvm.func @amdgpu_fp_unsafe_atomics() attributes {amdgpu_fp_unsafe_atomics = true} {
// CHECK: @amdgpu_fp_unsafe_atomics
// CHECK-SAME: attributes {amdgpu_fp_unsafe_atomics = true}
llvm.return
}

// CHECK: llvm.comdat @__llvm_comdat
llvm.comdat @__llvm_comdat {
// CHECK: llvm.comdat_selector @any any
Expand Down
6 changes: 6 additions & 0 deletions mlir/test/Target/LLVMIR/Import/function-attributes.ll
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,12 @@ define void @arm_preserves_za_func() "aarch64_preserves_za" {
ret void
}

; // -----

; CHECK-LABEL: @func_attr_amdgpu_unsafe_fp_atomics_true
; CHECK-SAME: attributes {amdgpu_unsafe_fp_atomics = true}
declare void @func_attr_amdgpu_unsafe_fp_atomics_true() "amdgpu-unsafe-fp-atomics"="true"

// -----

; CHECK-LABEL: @section_func
Expand Down
9 changes: 9 additions & 0 deletions mlir/test/Target/LLVMIR/llvmir.mlir
Original file line number Diff line number Diff line change
Expand Up @@ -2474,6 +2474,15 @@ llvm.func @preserves_za_func() attributes {arm_preserves_za} {

// -----

// CHECK-LABEL: @amdgpu_unsafe_fp_atomics_func
// CHECK-SAME: #[[ATTR:[0-9]*]]
llvm.func @amdgpu_unsafe_fp_atomics_func() attributes {amdgpu_unsafe_fp_atomics = true} {
llvm.return
}
// CHECK: #[[ATTR]] = { "amdgpu-unsafe-fp-atomics"="true" }

// -----

//
// frame pointer attribute.
//
Expand Down