Skip to content

[lldb][NFC] Split RegisterContextUnwind::SavedLocationForRegister #139817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 10, 2025
Merged

[lldb][NFC] Split RegisterContextUnwind::SavedLocationForRegister #139817

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e63e53a
[lldb][NFC] Split RegisterContextUnwind::SavedLocationForRegister
jasonmolenda May 14, 2025
c1aad81
Remove another bit of code in GetAbstractRegisterLocation
jasonmolenda May 14, 2025
fde9122
Don't log a message when the ABI says this is a volatile register
jasonmolenda May 14, 2025
853da66
clarify comment.
jasonmolenda May 14, 2025
1f40042
make another pass over all the comments and
jasonmolenda May 14, 2025
967f99d
tiny edit
jasonmolenda May 14, 2025
eb6d742
Update lldb/source/Target/RegisterContextUnwind.cpp
jasonmolenda May 14, 2025
89c38a1
Still undecided about the documentation of GetAbstractRegisterLocation.
jasonmolenda May 14, 2025
70de109
typeo
jasonmolenda May 16, 2025
b349ca0
Merge branch 'main' into savedlocationforregister-nfc-cleanup
jasonmolenda Jun 9, 2025
74e0e98
Merge branch 'main' into savedlocationforregister-nfc-cleanup
jasonmolenda Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lldb/include/lldb/Target/RegisterContextUnwind.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,9 @@ class RegisterContextUnwind : public lldb_private::RegisterContext {
uint32_t lldb_regnum,
lldb_private::UnwindLLDB::ConcreteRegisterLocation &regloc);

std::optional<UnwindPlan::Row::AbstractRegisterLocation>
GetAbstractRegisterLocation(uint32_t lldb_regnum, lldb::RegisterKind &kind);

bool ReadRegisterValueFromRegisterLocation(
lldb_private::UnwindLLDB::ConcreteRegisterLocation regloc,
const lldb_private::RegisterInfo *reg_info,
Expand Down
Loading
Loading