Skip to content

Conversation

@oontvoo
Copy link
Member

@oontvoo oontvoo commented May 19, 2025

No description provided.

@oontvoo oontvoo requested a review from JDevlieghere as a code owner May 19, 2025 18:27
@llvmbot llvmbot added the lldb label May 19, 2025
@oontvoo oontvoo requested a review from labath May 19, 2025 18:28
@oontvoo oontvoo merged commit fe1c482 into llvm:main May 19, 2025
8 of 11 checks passed
@llvmbot
Copy link
Member

llvmbot commented May 19, 2025

@llvm/pr-subscribers-lldb

Author: Vy Nguyen (oontvoo)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/140588.diff

1 Files Affected:

  • (modified) lldb/test/Shell/Commands/list-header.test (+3-1)
diff --git a/lldb/test/Shell/Commands/list-header.test b/lldb/test/Shell/Commands/list-header.test
index 02630602b57d0..be77b9fa383ca 100644
--- a/lldb/test/Shell/Commands/list-header.test
+++ b/lldb/test/Shell/Commands/list-header.test
@@ -1,4 +1,6 @@
-# REQUIRES: x86
+## Does not work on windows (yet?) PDB debug-info likely does something wrong
+## with the header files.
+# XFAIL: system-windows
 
 ## Test that `list header.h:<line>` works correctly when header is available.
 ## 

@slydiman
Copy link
Contributor

slydiman commented May 19, 2025

https://lab.llvm.org/buildbot/#/builders/197/builds/5542 is broken.

Probably you must use XFAIL: target-windows instead of XFAIL: system-windows.
Please fix it ASAP or revert.

@oontvoo
Copy link
Member Author

oontvoo commented May 19, 2025

fixing now. thanks!

@oontvoo oontvoo deleted the fix_test branch May 19, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants