[HLSL][NFC] Add resource globals created for metadata to test baseline #140620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-backend-directx Author: Helena Kotas (hekota) ChangesAdds checks for resource globals that were created for DXIL metadata. The names of the globals and the names of the types will be changing soon. Adding these to the baseline will make it easier to see what is changing. Full diff: https://github.com/llvm/llvm-project/pull/140620.diff 2 Files Affected:
diff --git a/llvm/test/CodeGen/DirectX/Metadata/srv_metadata.ll b/llvm/test/CodeGen/DirectX/Metadata/srv_metadata.ll
index 63ead534f1276..03c801ff0372f 100644
--- a/llvm/test/CodeGen/DirectX/Metadata/srv_metadata.ll
+++ b/llvm/test/CodeGen/DirectX/Metadata/srv_metadata.ll
@@ -84,6 +84,15 @@ define void @test() #0 {
attributes #0 = { noinline nounwind "hlsl.shader"="compute" }
+; CHECK: @0 = external constant %TypedBuffer
+; CHECK: @1 = external constant %TypedBuffer.0
+; CHECK: @2 = external constant %TypedBuffer.1
+; CHECK: @3 = external constant %TypedBuffer.2
+; CHECK: @4 = external constant %ByteAddressBuffer
+; CHECK: @5 = external constant %StructuredBuffer
+; CHECK: @6 = external constant %TypedBuffer.3
+; CHECK: @7 = external constant %TypedBuffer.4
+
; CHECK: !dx.resources = !{[[ResList:[!][0-9]+]]}
; CHECK: [[ResList]] = !{[[SRVList:[!][0-9]+]], null, null, null}
diff --git a/llvm/test/CodeGen/DirectX/Metadata/uav_metadata.ll b/llvm/test/CodeGen/DirectX/Metadata/uav_metadata.ll
index e2f7cffb50f3c..98651e47d103d 100644
--- a/llvm/test/CodeGen/DirectX/Metadata/uav_metadata.ll
+++ b/llvm/test/CodeGen/DirectX/Metadata/uav_metadata.ll
@@ -108,6 +108,18 @@ define void @test() #0 {
attributes #0 = { noinline nounwind "hlsl.shader"="compute" }
+; CHECK: @0 = external constant %RWTypedBuffer
+; CHECK: @1 = external constant %RWTypedBuffer.0
+; CHECK: @2 = external constant %RWTypedBuffer.1
+; CHECK: @3 = external constant %RWTypedBuffer.2
+; CHECK: @4 = external constant %RWByteAddressBuffer
+; CHECK: @5 = external constant %RWStructuredBuffer
+; CHECK: @6 = external constant %RasterizerOrderedTypedBuffer
+; CHECK: @7 = external constant %RasterizerOrderedStructuredBuffer
+; CHECK: @8 = external constant %RasterizerOrderedByteAddressBuffer
+; CHECK: @9 = external constant %RWTypedBuffer.3
+; CHECK: @10 = external constant %RWTypedBuffer.4
+
; CHECK: !dx.resources = !{[[ResList:[!][0-9]+]]}
; CHECK: [[ResList]] = !{null, [[UAVList:[!][0-9]+]], null, null}
|
bogner
approved these changes
May 19, 2025
bob80905
approved these changes
May 19, 2025
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Jun 3, 2025
llvm#140620) Adds checks for resource globals that were created for DXIL metadata. The names of the globals and the names of the types will be changing soon. Adding these to the baseline will make it easier to see what is changing.
ajaden-codes
pushed a commit
to Jaddyen/llvm-project
that referenced
this pull request
Jun 6, 2025
llvm#140620) Adds checks for resource globals that were created for DXIL metadata. The names of the globals and the names of the types will be changing soon. Adding these to the baseline will make it easier to see what is changing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds checks for resource globals that were created for DXIL metadata. The names of the globals and the names of the types will be changing soon. Adding these to the baseline will make it easier to see what is changing.