Skip to content

[mlir][tosa] Fix indexing in TosaToTensor #140906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025
Merged

[mlir][tosa] Fix indexing in TosaToTensor #140906

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
216a5f2
[mlir][tosa] Fix indexing in TosaToTensor
May 21, 2025
41151d6
Added test which doesn't pass prior to change
May 22, 2025
6ce7fe5
Merge branch 'main' into shay-kl/fix-tensor-padop-indexing
shay-kl May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,8 @@ class PadConverter : public OpConversionPattern<tosa::PadOp> {
// Setup the default constantAttr.

Value padConstant = rewriter.createOrFold<tensor::ExtractOp>(
loc, padOp.getPadConst(), ValueRange({}));
loc, padOp.getPadConst(),
ValueRange({rewriter.create<arith::ConstantIndexOp>(loc, 0)}));

if (!padConstant) {
return rewriter.notifyMatchFailure(
Expand Down