[TableGen] Add missing $ before the dag operator name #140969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way the dump output is roundtripable.
|
@llvm/pr-subscribers-tablegen Author: Adam Nemet (anemet) ChangesThis way the dump output is roundtripable. Full diff: https://github.com/llvm/llvm-project/pull/140969.diff 2 Files Affected:
diff --git a/llvm/lib/TableGen/Record.cpp b/llvm/lib/TableGen/Record.cpp
index 2f991d5fec165..12f5ce6175dbf 100644
--- a/llvm/lib/TableGen/Record.cpp
+++ b/llvm/lib/TableGen/Record.cpp
@@ -2786,7 +2786,7 @@ bool DagInit::isConcrete() const {
std::string DagInit::getAsString() const {
std::string Result = "(" + Val->getAsString();
if (ValName)
- Result += ":" + ValName->getAsUnquotedString();
+ Result += ":$" + ValName->getAsUnquotedString();
if (!arg_empty()) {
Result += " ";
ListSeparator LS;
diff --git a/llvm/test/TableGen/usevalname.td b/llvm/test/TableGen/usevalname.td
index d85b98ac33e64..ab90398cde49c 100644
--- a/llvm/test/TableGen/usevalname.td
+++ b/llvm/test/TableGen/usevalname.td
@@ -20,5 +20,5 @@ multiclass shuffle<Reg RC> {
RC:$src1, RC:$src2))]>;
}
-// CHECK: shufp:src3
+// CHECK: shufp:$src3
defm ADD : shuffle<VR128>;
|
jurahul
approved these changes
May 21, 2025
fpetrogalli
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way the dump output is roundtripable.