[AMDGPU] Introduce FeatureISAVersion11_5_Common. NFC. #141061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just removes some duplication in the features lists for gfx115x.
Member
|
@llvm/pr-subscribers-backend-amdgpu Author: Jay Foad (jayfoad) ChangesThis just removes some duplication in the features lists for gfx115x. Full diff: https://github.com/llvm/llvm-project/pull/141061.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AMDGPU/AMDGPU.td b/llvm/lib/Target/AMDGPU/AMDGPU.td
index 764a7a9bf5e52..18f334d343d97 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPU.td
+++ b/llvm/lib/Target/AMDGPU/AMDGPU.td
@@ -1819,33 +1819,28 @@ def FeatureISAVersion11_0_3 : FeatureSet<
!listconcat(FeatureISAVersion11_0_Common.Features,
[])>;
-def FeatureISAVersion11_5_0 : FeatureSet<
+def FeatureISAVersion11_5_Common : FeatureSet<
!listconcat(FeatureISAVersion11_Common.Features,
[FeatureSALUFloatInsts,
FeatureDPPSrc1SGPR,
- FeatureRequiredExportPriority,
- FeaturePointSampleAccel])>;
+ FeatureRequiredExportPriority])>;
+
+def FeatureISAVersion11_5_0 : FeatureSet<
+ !listconcat(FeatureISAVersion11_5_Common.Features,
+ [FeaturePointSampleAccel])>;
def FeatureISAVersion11_5_1 : FeatureSet<
- !listconcat(FeatureISAVersion11_Common.Features,
- [FeatureSALUFloatInsts,
- FeatureDPPSrc1SGPR,
- Feature1_5xVGPRs,
- FeatureRequiredExportPriority,
+ !listconcat(FeatureISAVersion11_5_Common.Features,
+ [Feature1_5xVGPRs,
FeaturePointSampleAccel])>;
def FeatureISAVersion11_5_2 : FeatureSet<
- !listconcat(FeatureISAVersion11_Common.Features,
- [FeatureSALUFloatInsts,
- FeatureDPPSrc1SGPR,
- FeatureRequiredExportPriority,
- FeaturePointSampleAccel])>;
+ !listconcat(FeatureISAVersion11_5_Common.Features,
+ [FeaturePointSampleAccel])>;
def FeatureISAVersion11_5_3 : FeatureSet<
- !listconcat(FeatureISAVersion11_Common.Features,
- [FeatureSALUFloatInsts,
- FeatureDPPSrc1SGPR,
- FeatureRequiredExportPriority])>;
+ !listconcat(FeatureISAVersion11_5_Common.Features,
+ [])>;
def FeatureISAVersion12 : FeatureSet<
[FeatureGFX12,
|
mbrkusanin
approved these changes
May 22, 2025
mariusz-sikora-at-amd
approved these changes
May 22, 2025
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/8910 Here is the relevant piece of the build log for the reference |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/11666 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just removes some duplication in the features lists for gfx115x.