Skip to content

Conversation

@tgymnich
Copy link
Member

@tgymnich tgymnich commented May 23, 2025

Move GenericFloatingPointPredicateUtils from ADT to IR to fix linkage

@tgymnich tgymnich marked this pull request as ready for review May 23, 2025 17:17
@llvmbot llvmbot added llvm:globalisel llvm:ir llvm:analysis Includes value tracking, cost tables and constant folding labels May 23, 2025
@llvmbot
Copy link
Member

llvmbot commented May 23, 2025

@llvm/pr-subscribers-llvm-analysis

@llvm/pr-subscribers-llvm-globalisel

Author: Tim Gymnich (tgymnich)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/141260.diff

3 Files Affected:

  • (modified) llvm/include/llvm/Analysis/FloatingPointPredicateUtils.h (+1-1)
  • (modified) llvm/include/llvm/CodeGen/GlobalISel/MachineFloatingPointPredicateUtils.h (+1-1)
  • (renamed) llvm/include/llvm/IR/GenericFloatingPointPredicateUtils.h ()
diff --git a/llvm/include/llvm/Analysis/FloatingPointPredicateUtils.h b/llvm/include/llvm/Analysis/FloatingPointPredicateUtils.h
index 96fdbf48d8b43..c1824950b55c4 100644
--- a/llvm/include/llvm/Analysis/FloatingPointPredicateUtils.h
+++ b/llvm/include/llvm/Analysis/FloatingPointPredicateUtils.h
@@ -9,7 +9,7 @@
 #ifndef LLVM_ANALYSIS_FLOATINGPOINTPREDICATEUTILS_H
 #define LLVM_ANALYSIS_FLOATINGPOINTPREDICATEUTILS_H
 
-#include "llvm/ADT/GenericFloatingPointPredicateUtils.h"
+#include "llvm/IR/GenericFloatingPointPredicateUtils.h"
 #include "llvm/IR/SSAContext.h"
 
 namespace llvm {
diff --git a/llvm/include/llvm/CodeGen/GlobalISel/MachineFloatingPointPredicateUtils.h b/llvm/include/llvm/CodeGen/GlobalISel/MachineFloatingPointPredicateUtils.h
index 1a965665af278..d13e4dafe4e53 100644
--- a/llvm/include/llvm/CodeGen/GlobalISel/MachineFloatingPointPredicateUtils.h
+++ b/llvm/include/llvm/CodeGen/GlobalISel/MachineFloatingPointPredicateUtils.h
@@ -9,7 +9,7 @@
 #ifndef LLVM_CODEGEN_MACHINEFLOATINGPOINTPREDICATEUTILS_H
 #define LLVM_CODEGEN_MACHINEFLOATINGPOINTPREDICATEUTILS_H
 
-#include "llvm/ADT/GenericFloatingPointPredicateUtils.h"
+#include "llvm/IR/GenericFloatingPointPredicateUtils.h"
 #include "llvm/CodeGen/MachineSSAContext.h"
 
 namespace llvm {
diff --git a/llvm/include/llvm/ADT/GenericFloatingPointPredicateUtils.h b/llvm/include/llvm/IR/GenericFloatingPointPredicateUtils.h
similarity index 100%
rename from llvm/include/llvm/ADT/GenericFloatingPointPredicateUtils.h
rename to llvm/include/llvm/IR/GenericFloatingPointPredicateUtils.h

@llvmbot
Copy link
Member

llvmbot commented May 23, 2025

@llvm/pr-subscribers-llvm-ir

Author: Tim Gymnich (tgymnich)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/141260.diff

3 Files Affected:

  • (modified) llvm/include/llvm/Analysis/FloatingPointPredicateUtils.h (+1-1)
  • (modified) llvm/include/llvm/CodeGen/GlobalISel/MachineFloatingPointPredicateUtils.h (+1-1)
  • (renamed) llvm/include/llvm/IR/GenericFloatingPointPredicateUtils.h ()
diff --git a/llvm/include/llvm/Analysis/FloatingPointPredicateUtils.h b/llvm/include/llvm/Analysis/FloatingPointPredicateUtils.h
index 96fdbf48d8b43..c1824950b55c4 100644
--- a/llvm/include/llvm/Analysis/FloatingPointPredicateUtils.h
+++ b/llvm/include/llvm/Analysis/FloatingPointPredicateUtils.h
@@ -9,7 +9,7 @@
 #ifndef LLVM_ANALYSIS_FLOATINGPOINTPREDICATEUTILS_H
 #define LLVM_ANALYSIS_FLOATINGPOINTPREDICATEUTILS_H
 
-#include "llvm/ADT/GenericFloatingPointPredicateUtils.h"
+#include "llvm/IR/GenericFloatingPointPredicateUtils.h"
 #include "llvm/IR/SSAContext.h"
 
 namespace llvm {
diff --git a/llvm/include/llvm/CodeGen/GlobalISel/MachineFloatingPointPredicateUtils.h b/llvm/include/llvm/CodeGen/GlobalISel/MachineFloatingPointPredicateUtils.h
index 1a965665af278..d13e4dafe4e53 100644
--- a/llvm/include/llvm/CodeGen/GlobalISel/MachineFloatingPointPredicateUtils.h
+++ b/llvm/include/llvm/CodeGen/GlobalISel/MachineFloatingPointPredicateUtils.h
@@ -9,7 +9,7 @@
 #ifndef LLVM_CODEGEN_MACHINEFLOATINGPOINTPREDICATEUTILS_H
 #define LLVM_CODEGEN_MACHINEFLOATINGPOINTPREDICATEUTILS_H
 
-#include "llvm/ADT/GenericFloatingPointPredicateUtils.h"
+#include "llvm/IR/GenericFloatingPointPredicateUtils.h"
 #include "llvm/CodeGen/MachineSSAContext.h"
 
 namespace llvm {
diff --git a/llvm/include/llvm/ADT/GenericFloatingPointPredicateUtils.h b/llvm/include/llvm/IR/GenericFloatingPointPredicateUtils.h
similarity index 100%
rename from llvm/include/llvm/ADT/GenericFloatingPointPredicateUtils.h
rename to llvm/include/llvm/IR/GenericFloatingPointPredicateUtils.h

@tgymnich tgymnich changed the title GenericFloatingPointPredicateUtils to fix linkage Move GenericFloatingPointPredicateUtils to IR to fix linkage May 23, 2025
@github-actions
Copy link

github-actions bot commented May 23, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

@tgymnich tgymnich force-pushed the tim/fix-fp-predicate-utils-build-2 branch from cd91492 to 7c9704b Compare May 23, 2025 17:21
@tgymnich tgymnich force-pushed the tim/fix-fp-predicate-utils-build-2 branch from 7c9704b to 702b736 Compare May 23, 2025 17:21
@tgymnich tgymnich closed this May 23, 2025
@tgymnich tgymnich deleted the tim/fix-fp-predicate-utils-build-2 branch May 23, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

llvm:analysis Includes value tracking, cost tables and constant folding llvm:globalisel llvm:ir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants