diff --git a/llvm/lib/Analysis/ConstantFolding.cpp b/llvm/lib/Analysis/ConstantFolding.cpp index 40302fbc8ee52..2476dc58375e5 100644 --- a/llvm/lib/Analysis/ConstantFolding.cpp +++ b/llvm/lib/Analysis/ConstantFolding.cpp @@ -3794,11 +3794,6 @@ static Constant *ConstantFoldScalableVectorCall( SplatOps.push_back(Op); continue; } - // TODO: Should getSplatValue return a poison scalar for a poison vector? - if (isa(Op)) { - SplatOps.push_back(PoisonValue::get(Op->getType()->getScalarType())); - continue; - } Constant *Splat = Op->getSplatValue(); if (!Splat) return nullptr; diff --git a/llvm/lib/Analysis/TargetTransformInfo.cpp b/llvm/lib/Analysis/TargetTransformInfo.cpp index 0f857399660fe..2d053e55bdfa9 100644 --- a/llvm/lib/Analysis/TargetTransformInfo.cpp +++ b/llvm/lib/Analysis/TargetTransformInfo.cpp @@ -886,6 +886,10 @@ TargetTransformInfo::getOperandInfo(const Value *V) { OperandValueKind OpInfo = OK_AnyValue; OperandValueProperties OpProps = OP_None; + // undef/poison don't materialize constants. + if (isa(V)) + return {OK_AnyValue, OP_None}; + if (isa(V) || isa(V)) { if (const auto *CI = dyn_cast(V)) { if (CI->getValue().isPowerOf2()) diff --git a/llvm/lib/IR/Constants.cpp b/llvm/lib/IR/Constants.cpp index fa453309b34ee..a3c725b2af62a 100644 --- a/llvm/lib/IR/Constants.cpp +++ b/llvm/lib/IR/Constants.cpp @@ -1711,6 +1711,8 @@ void ConstantVector::destroyConstantImpl() { Constant *Constant::getSplatValue(bool AllowPoison) const { assert(this->getType()->isVectorTy() && "Only valid for vectors!"); + if (isa(this)) + return PoisonValue::get(cast(getType())->getElementType()); if (isa(this)) return getNullValue(cast(getType())->getElementType()); if (auto *CI = dyn_cast(this))