[libc] wmemcmp nullptr handling #142058
Merged
[libc] wmemcmp nullptr handling #142058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 29, 2025 22:57
Added nullptr handling for wmemcmp
|
@llvm/pr-subscribers-libc Author: None (sribee8) ChangesAdded nullptr handling for wmemcmp Full diff: https://github.com/llvm/llvm-project/pull/142058.diff 1 Files Affected:
diff --git a/libc/src/wchar/wmemcmp.cpp b/libc/src/wchar/wmemcmp.cpp
index f2fa361c69798..374f3d5ddb627 100644
--- a/libc/src/wchar/wmemcmp.cpp
+++ b/libc/src/wchar/wmemcmp.cpp
@@ -12,11 +12,14 @@
#include "hdr/types/wchar_t.h"
#include "src/__support/common.h"
#include "src/__support/macros/config.h"
+#include "src/__support/macros/null_check.h" // LIBC_CRASH_ON_NULLPTR
namespace LIBC_NAMESPACE_DECL {
LLVM_LIBC_FUNCTION(int, wmemcmp,
(const wchar_t *s1, const wchar_t *s2, size_t n)) {
+ LIBC_CRASH_ON_NULLPTR(s1);
+ LIBC_CRASH_ON_NULLPTR(s2);
for (size_t i = 0; i < n; ++i) {
if (s1[i] != s2[i])
return (int)(s1[i] - s2[i]);
|
michaelrj-google
approved these changes
May 29, 2025
lntue
reviewed
May 30, 2025
|
Can you sync pass #142085 and add death tests for these cases? |
lntue
reviewed
May 30, 2025
lntue
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added nullptr handling for wmemcmp