Skip to content

[mlir] [docs] Minor documentation fix in mlir-reduce docs #142479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[mlir] [docs] Minor documentation fix in mlir-reduce docs #142479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mlir/docs/Tools/mlir-reduce.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ results and different time complexity. You can run as
As mentioned, you need to provide a command to `mlir-reduce` which identifies
cases you're interested in. For each intermediate output generated during
reduction, `mlir-reduce` will run the command over the it, the script should
returns 1 for interesting case, 0 otherwise. The sample script,
returns 0 for an interesting case, 1 otherwise. The sample script,
Copy link
Collaborator

@joker-eph joker-eph Jun 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite get the change, can you elaborate? The existing sentence seems correct with respect to the code sample below.


```shell
mlir-opt -convert-vector-to-spirv $1 | grep "failed to materialize"
Expand Down
Loading