diff --git a/libcxx/cmake/caches/AndroidNDK.cmake b/libcxx/cmake/caches/AndroidNDK.cmake index 298518781e9b7..1a04b7fbb217d 100644 --- a/libcxx/cmake/caches/AndroidNDK.cmake +++ b/libcxx/cmake/caches/AndroidNDK.cmake @@ -33,5 +33,5 @@ set(CMAKE_CXX_COMPILER_WORKS ON CACHE BOOL "") # Use adb to push tests to a locally-connected device (e.g. emulator) and run # them. -set(LIBCXX_TEST_CONFIG "llvm-libc++-android-ndk.cfg.in" CACHE STRING "") -set(LIBCXXABI_TEST_CONFIG "llvm-libc++abi-android-ndk.cfg.in" CACHE STRING "") +set(LIBCXX_TEST_CONFIG "llvm-libc++-android.cfg.in" CACHE STRING "") +set(LIBCXXABI_TEST_CONFIG "llvm-libc++abi-android.cfg.in" CACHE STRING "") diff --git a/libcxx/test/configs/llvm-libc++-android-ndk.cfg.in b/libcxx/test/configs/llvm-libc++-android.cfg.in similarity index 83% rename from libcxx/test/configs/llvm-libc++-android-ndk.cfg.in rename to libcxx/test/configs/llvm-libc++-android.cfg.in index 31a07f6471651..9362c68e8f7a8 100644 --- a/libcxx/test/configs/llvm-libc++-android-ndk.cfg.in +++ b/libcxx/test/configs/llvm-libc++-android.cfg.in @@ -1,5 +1,5 @@ # This testing configuration handles running the test suite against LLVM's -# libc++ using adb and a libc++_shared.so library on Android. +# libc++ using adb on Android. lit_config.load_config(config, '@CMAKE_CURRENT_BINARY_DIR@/cmake-bridge.cfg') @@ -27,11 +27,11 @@ if re.match(r'i686-linux-android(21|22|23)$', config.target_triple): compile_flags += ' -mstackrealign' config.substitutions.append(('%{compile_flags}', compile_flags)) -# The NDK library is called "libc++_shared.so". Use LD_LIBRARY_PATH to find -# libc++_shared.so because older Bionic dynamic loaders don't support rpath -# lookup. +# The platform library is called "libc++.so" and the NDK library is called "libc++_shared.so". +# Use LD_LIBRARY_PATH to find the libcxx shared object because older Bionic dynamic loaders +# don't support rpath lookup. config.substitutions.append(('%{link_flags}', - '-nostdlib++ -L %{lib-dir} -lc++_shared' + '-nostdlib++ -L %{lib-dir} -l@LIBCXX_SHARED_OUTPUT_NAME@' )) config.substitutions.append(('%{exec}', '%{executor}' + diff --git a/libcxxabi/test/configs/llvm-libc++abi-android-ndk.cfg.in b/libcxxabi/test/configs/llvm-libc++abi-android.cfg.in similarity index 72% rename from libcxxabi/test/configs/llvm-libc++abi-android-ndk.cfg.in rename to libcxxabi/test/configs/llvm-libc++abi-android.cfg.in index f2cb62a32d4e8..bc58446615361 100644 --- a/libcxxabi/test/configs/llvm-libc++abi-android-ndk.cfg.in +++ b/libcxxabi/test/configs/llvm-libc++abi-android.cfg.in @@ -1,5 +1,5 @@ # This testing configuration handles running the test suite against LLVM's -# libc++abi using adb and a libc++_shared.so library on Android. +# libc++abi using adb on Android. lit_config.load_config(config, '@CMAKE_CURRENT_BINARY_DIR@/cmake-bridge.cfg') @@ -19,12 +19,12 @@ config.substitutions.append(('%{compile_flags}', '-nostdinc++ -I %{include} -I %{cxx-include} -I %{cxx-target-include} %{maybe-include-libunwind} -I %{libcxx}/test/support -I %{libcxx}/src -D_LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS' )) -# The NDK library is called "libc++_shared.so". Use LD_LIBRARY_PATH to find -# libc++_shared.so because older Bionic dynamic loaders don't support rpath -# lookup. The Android libc++ shared library exports libc++abi, so we don't need -# to link with -lc++abi. +# The platform library is called "libc++.so" and the NDK library is called "libc++_shared.so". +# Use LD_LIBRARY_PATH to find the libcxx shared object because older Bionic dynamic loaders +# don't support rpath lookup. The Android libc++ shared library exports libc++abi, so we +# don't need to link with -lc++abi. config.substitutions.append(('%{link_flags}', - '-nostdlib++ -L %{lib} -lc++_shared' + '-nostdlib++ -L %{lib} -l@LIBCXX_SHARED_OUTPUT_NAME@' )) config.substitutions.append(('%{exec}', '%{executor}' +