Skip to content

Fix error that reference to PointerType is ambiguous in clang/lib/Analysis/UnsafeBufferUsage.cpp #142966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abhina-sree merged 2 commits into from
Jun 5, 2025
Merged

Fix error that reference to PointerType is ambiguous in clang/lib/Analysis/UnsafeBufferUsage.cpp #142966

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f536c94
fix error that reference to PointerType is ambiguous
abhina-sree Jun 5, 2025
07c8b2a
remove using namespace llvm instead
abhina-sree Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions clang/lib/Analysis/UnsafeBufferUsage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,11 +247,11 @@ class MatchDescendantVisitor : public DynamicRecursiveASTVisitor {

// Because we're dealing with raw pointers, let's define what we mean by that.
static bool hasPointerType(const Expr &E) {
return isa<PointerType>(E.getType().getCanonicalType());
return isa<clang::PointerType>(E.getType().getCanonicalType());
}

static bool hasArrayType(const Expr &E) {
return isa<ArrayType>(E.getType().getCanonicalType());
return isa<clang::ArrayType>(E.getType().getCanonicalType());
}

static void
Expand Down Expand Up @@ -968,7 +968,8 @@ static bool hasUnsafePrintfStringArg(const CallExpr &Node, ASTContext &Ctx,
if (!FirstParmTy->isPointerType())
return false; // possibly some user-defined printf function

QualType FirstPteTy = FirstParmTy->castAs<PointerType>()->getPointeeType();
QualType FirstPteTy =
FirstParmTy->castAs<clang::PointerType>()->getPointeeType();

if (!Ctx.getFILEType()
.isNull() && //`FILE *` must be in the context if it is fprintf
Expand Down Expand Up @@ -1052,7 +1053,8 @@ static bool hasUnsafeSnprintfBuffer(const CallExpr &Node,
if (!FirstParmTy->isPointerType())
return false; // Not an snprint

QualType FirstPteTy = FirstParmTy->castAs<PointerType>()->getPointeeType();
QualType FirstPteTy =
FirstParmTy->castAs<clang::PointerType>()->getPointeeType();
const Expr *Buf = Node.getArg(0), *Size = Node.getArg(1);

if (FirstPteTy.isConstQualified() || !Buf->getType()->isPointerType() ||
Expand Down
Loading